RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-02-16 18:46:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: dns: don't downgrade DNS accepted payload size automatically

Browse Source 
Automatic downgrade of DNS accepted payload size may have undesired side
effect, which could make a backend with all servers DOWN.

After talking with Lukas on the ML, I realized this "feature" introduces
more issues that it fixes problem.
The "best" way to handle properly big responses will be to implement DNS
over TCP.

To be backported to 1.8.
This commit is contained in:
Baptiste Assmann 2018-03-01 22:26:57 +01:00 committed by Willy Tarreau
parent 5cd4bbd7ab
commit 1fa7d2acce
2 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
doc/configuration.txt
View File

@ -12009,9 +12009,6 @@ accepted_payload_size <nb>
<nb> is in bytes. If not set, HAProxy announces 512. (minimal value defined
by RFC 6891)
Note: to get bigger responses but still be sure that responses won't be
dropped on the wire, one can choose a value between 1280 and 1410.
Note: the maximum allowed value is 8192.
nameserver <id> <ip>:<port>

6
src/dns.c
View File

@ -1733,12 +1733,6 @@ static struct task *dns_process_resolvers(struct task *t)
dns_reset_resolution(res);
LIST_DEL(&res->list);
LIST_ADDQ(&resolvers->resolutions.wait, &res->list);
/* This might be triggered by too big UDP packets
* dropped somewhere on the network, so lowering the
* accepted_payload_size announced */
if (resolvers->accepted_payload_size > 1280)
resolvers->accepted_payload_size = 1280;
}
else {
/* Otherwise resend the DNS query and requeue the resolution */