From 1e1c28873ccdc9e9f7ca24bb533023a62ae3886e Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Wed, 24 May 2023 15:23:34 +0200 Subject: [PATCH] BUILD: makefile: fix build issue on GNU make < 3.82 Thierry Fournier reported a build breakage with the ubiquitous make 3.81, LDFLAGS were ignored. This is caused by the declaration of the collect_opt_flags macro that is defined with an "=" sign, something that only appeared in 3.82 and that is not necessary. With it removed, the build now works fine at least from 3.80 to 4.3. No backport is needed since this makefile cleanup appeared in 2.8. --- include/make/options.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/make/options.mk b/include/make/options.mk index 1f9aaba69..022981cb8 100644 --- a/include/make/options.mk +++ b/include/make/options.mk @@ -39,7 +39,7 @@ reset_opt_vars = $(foreach name,INC LIB CFLAGS LDFLAGS SRC,$(eval $(1)_$(name)=) reset_opts_vars = $(foreach opt,$(patsubst USE_%,%,$(use_opts)),$(call reset_opt_vars,$(opt))) # append $(1)_{C,LD}FLAGS into OPTIONS_{C,LD}FLAGS if not empty -define collect_opt_flags = +define collect_opt_flags ifneq ($$($(1)_CFLAGS),) OPTIONS_CFLAGS += $$($(1)_CFLAGS) endif