RepoMirrors
/
haproxy
mirror of http://git.haproxy.org/git/haproxy.git/
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MINOR: stats: also report the failed header rewrites warnings on the stats page 

These ones concern the warnings detected during header addition/insertion.
They are visible in the tooltip reporting the per-status codes stats. The
frontend and backend contain a total of request+response warnings, while
server only has the response warnings.
This commit is contained in:
Willy Tarreau 2018-05-28 15:12:40 +02:00
parent ea96a823c6
commit 1b0f85e47f
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/stats.c
View File

@ -689,6 +689,7 @@ static int stats_dump_fields_html(struct chunk *out, const struct field *stats,
"<tr><th>- HTTP 5xx responses:</th><td>%s</td></tr>" "<tr><th>- HTTP 5xx responses:</th><td>%s</td></tr>"
"<tr><th>- other responses:</th><td>%s</td></tr>" "<tr><th>- other responses:</th><td>%s</td></tr>"
"<tr><th>Intercepted requests:</th><td>%s</td></tr>" "<tr><th>Intercepted requests:</th><td>%s</td></tr>"
"<tr><th>Failed hdr rewrites:</th><td>%s</td></tr>"
"", "",
U2H(stats[ST_F_REQ_TOT].u.u64), U2H(stats[ST_F_REQ_TOT].u.u64),
U2H(stats[ST_F_HRSP_1XX].u.u64), U2H(stats[ST_F_HRSP_1XX].u.u64),
@ -700,7 +701,8 @@ static int stats_dump_fields_html(struct chunk *out, const struct field *stats,
U2H(stats[ST_F_HRSP_4XX].u.u64), U2H(stats[ST_F_HRSP_4XX].u.u64),
U2H(stats[ST_F_HRSP_5XX].u.u64), U2H(stats[ST_F_HRSP_5XX].u.u64),
U2H(stats[ST_F_HRSP_OTHER].u.u64), U2H(stats[ST_F_HRSP_OTHER].u.u64),
U2H(stats[ST_F_INTERCEPTED].u.u64)); U2H(stats[ST_F_INTERCEPTED].u.u64),
U2H(stats[ST_F_WREW].u.u64));
} }
chunk_appendf(out, chunk_appendf(out,
@ -932,6 +934,7 @@ static int stats_dump_fields_html(struct chunk *out, const struct field *stats,
"<tr><th>- HTTP 4xx responses:</th><td>%s</td><td>(%d%%)</td></tr>" "<tr><th>- HTTP 4xx responses:</th><td>%s</td><td>(%d%%)</td></tr>"
"<tr><th>- HTTP 5xx responses:</th><td>%s</td><td>(%d%%)</td></tr>" "<tr><th>- HTTP 5xx responses:</th><td>%s</td><td>(%d%%)</td></tr>"
"<tr><th>- other responses:</th><td>%s</td><td>(%d%%)</td></tr>" "<tr><th>- other responses:</th><td>%s</td><td>(%d%%)</td></tr>"
"<tr><th>Failed hdr rewrites:</th><td>%s</td></tr>"
"", "",
U2H(tot), U2H(tot),
U2H(stats[ST_F_HRSP_1XX].u.u64), tot ? (int)(100 * stats[ST_F_HRSP_1XX].u.u64 / tot) : 0, U2H(stats[ST_F_HRSP_1XX].u.u64), tot ? (int)(100 * stats[ST_F_HRSP_1XX].u.u64 / tot) : 0,
@ -939,7 +942,8 @@ static int stats_dump_fields_html(struct chunk *out, const struct field *stats,
U2H(stats[ST_F_HRSP_3XX].u.u64), tot ? (int)(100 * stats[ST_F_HRSP_3XX].u.u64 / tot) : 0, U2H(stats[ST_F_HRSP_3XX].u.u64), tot ? (int)(100 * stats[ST_F_HRSP_3XX].u.u64 / tot) : 0,
U2H(stats[ST_F_HRSP_4XX].u.u64), tot ? (int)(100 * stats[ST_F_HRSP_4XX].u.u64 / tot) : 0, U2H(stats[ST_F_HRSP_4XX].u.u64), tot ? (int)(100 * stats[ST_F_HRSP_4XX].u.u64 / tot) : 0,
U2H(stats[ST_F_HRSP_5XX].u.u64), tot ? (int)(100 * stats[ST_F_HRSP_5XX].u.u64 / tot) : 0, U2H(stats[ST_F_HRSP_5XX].u.u64), tot ? (int)(100 * stats[ST_F_HRSP_5XX].u.u64 / tot) : 0,
U2H(stats[ST_F_HRSP_OTHER].u.u64), tot ? (int)(100 * stats[ST_F_HRSP_OTHER].u.u64 / tot) : 0); U2H(stats[ST_F_HRSP_OTHER].u.u64), tot ? (int)(100 * stats[ST_F_HRSP_OTHER].u.u64 / tot) : 0,
U2H(stats[ST_F_WREW].u.u64));
} }
chunk_appendf(out, "<tr><th colspan=3>Avg over last 1024 success. conn.</th></tr>"); chunk_appendf(out, "<tr><th colspan=3>Avg over last 1024 success. conn.</th></tr>");
@ -1151,6 +1155,7 @@ static int stats_dump_fields_html(struct chunk *out, const struct field *stats,
"<tr><th>- HTTP 4xx responses:</th><td>%s</td></tr>" "<tr><th>- HTTP 4xx responses:</th><td>%s</td></tr>"
"<tr><th>- HTTP 5xx responses:</th><td>%s</td></tr>" "<tr><th>- HTTP 5xx responses:</th><td>%s</td></tr>"
"<tr><th>- other responses:</th><td>%s</td></tr>" "<tr><th>- other responses:</th><td>%s</td></tr>"
"<tr><th>Failed hdr rewrites:</th><td>%s</td></tr>"
"<tr><th colspan=3>Avg over last 1024 success. conn.</th></tr>" "<tr><th colspan=3>Avg over last 1024 success. conn.</th></tr>"
"", "",
U2H(stats[ST_F_REQ_TOT].u.u64), U2H(stats[ST_F_REQ_TOT].u.u64),
@ -1162,6 +1167,7 @@ static int stats_dump_fields_html(struct chunk *out, const struct field *stats,
U2H(stats[ST_F_HRSP_3XX].u.u64), U2H(stats[ST_F_HRSP_3XX].u.u64),
U2H(stats[ST_F_HRSP_4XX].u.u64), U2H(stats[ST_F_HRSP_4XX].u.u64),
U2H(stats[ST_F_HRSP_5XX].u.u64), U2H(stats[ST_F_HRSP_5XX].u.u64),
U2H(stats[ST_F_WREW].u.u64),
U2H(stats[ST_F_HRSP_OTHER].u.u64)); U2H(stats[ST_F_HRSP_OTHER].u.u64));
} }