RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-01-16 02:30:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: signal: signal handler does not properly check for signal bounds

Browse Source 
sig is checked for < 0 or > MAX_SIGNAL, but the signal array is
MAX_SIGNAL in size. At the moment, MAX_SIGNAL is 256. If a system supports
more than MAX_SIGNAL signals, then sending signal MAX_SIGNAL to the process
will corrupt one integer in its memory and might also crash the process.

This bug is also present in 1.4 and 1.3, and the fix must be backported.

Reported-by: Dinko Korunic <dkorunic@reflected.net>
This commit is contained in:
Willy Tarreau 2013-01-24 02:06:05 +01:00
parent 8ab505bdef
commit 1a53b5ef58
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/signal.c
View File

@ -37,7 +37,7 @@ int signal_pending = 0; /* non-zero if t least one signal remains unprocessed */
*/
void signal_handler(int sig)
{
if (sig < 0 || sig > MAX_SIGNAL) {
if (sig < 0 || sig >= MAX_SIGNAL) {
/* unhandled signal */
signal(sig, SIG_IGN);
qfprintf(stderr, "Received unhandled signal %d. Signal has been disabled.\n", sig);
@ -142,7 +142,7 @@ struct sig_handler *signal_register_fct(int sig, void (*fct)(struct sig_handler
{
struct sig_handler *sh;
if (sig < 0 || sig > MAX_SIGNAL)
if (sig < 0 || sig >= MAX_SIGNAL)
return NULL;
if (sig)
@ -174,7 +174,7 @@ struct sig_handler *signal_register_task(int sig, struct task *task, int reason)
{
struct sig_handler *sh;
if (sig < 0 || sig > MAX_SIGNAL)
if (sig < 0 || sig >= MAX_SIGNAL)
return NULL;
if (sig)
@ -213,7 +213,7 @@ void signal_unregister_target(int sig, void *target)
{
struct sig_handler *sh, *shb;
if (sig < 0 || sig > MAX_SIGNAL)
if (sig < 0 || sig >= MAX_SIGNAL)
return;
if (!target)