RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2024-12-14 15:34:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: tcp: don't require privileges to bind to device

Browse Source 
Ankit Malp reported a bug that we've had since binding to devices was
implemented. Haproxy wrongly checks that the process stays privileged
after startup when a binding to a device is specified via the bind
keyword "interface". This is wrong, because after startup we're not
binding any socket anymore, and during startup if there's a permission
issue it will be immediately reported ("permission denied"). More
importantly there's no way around it as the process exits on startup
when facing such an option.

This fix should be backported to 1.7, 1.6 and 1.5.
This commit is contained in:
Willy Tarreau 2017-03-27 16:22:59 +02:00
parent 98a3e3f998
commit 19060a3020
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/proto_tcp.c
View File

@ -1698,7 +1698,6 @@ static int bind_parse_interface(char **args, int cur_arg, struct proxy *px, stru
l->interface = strdup(args[cur_arg + 1]); l->interface = strdup(args[cur_arg + 1]);
} }
global.last_checks |= LSTCHK_NETADM;
return 0; return 0;
} }
#endif #endif