RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-03-23 11:27:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MINOR: lua funtion hlua_socket_settimeout don't check negative values

Browse Source 
Negatives timeouts doesn't have sense. A negative timeout doesn't cause
a crash, but the connection expires before the system try to extablish it.

This patch should be backported in all versions from 1.6
This commit is contained in:
Thierry Fournier 2018-03-08 09:59:02 +01:00 committed by Willy Tarreau
parent e9636f192a
commit 17a921b799
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/hlua.c
View File

@ -2474,6 +2474,10 @@ __LJMP static int hlua_socket_settimeout(struct lua_State *L)
socket = MAY_LJMP(hlua_checksocket(L, 1));
tmout = MAY_LJMP(luaL_checkinteger(L, 2)) * 1000;
/* Check for negative values */
if (tmout < 0)
WILL_LJMP(luaL_error(L, "settimeout: cannot set negatives values"));
/* Check if we run on the same thread than the xreator thread.
* We cannot access to the socket if the thread is different.
*/