RepoMirrors
/
haproxy
mirror of http://git.haproxy.org/git/haproxy.git/
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

MINOR: pools: report a replaced memory allocator instead of just malloc_trim() 

Instead of reporting the inaccurate "malloc_trim() support" on -vv, let's
report the case where the memory allocator was actively replaced from the
one used at build time, as this is the corner case we want to be cautious
about. We also put a tainted bit when this happens so that it's possible
to detect it at run time (e.g. the user might have inherited it from an
environment variable during a reload operation).

The now unused is_trim_enabled() function was finally dropped.
This commit is contained in:
Willy Tarreau 2023-03-22 18:01:41 +01:00
parent 0c27ec5df7
commit 1751db140a
3 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/haproxy/bug.h
View File

@ -221,6 +221,7 @@ enum tainted_flags {
TAINTED_BUG = 0x00000020, /* a BUG_ON triggered */
TAINTED_SHARED_LIBS = 0x00000040, /* a shared library was loaded */
TAINTED_REDEFINITION = 0x00000080, /* symbol redefinition detected */
TAINTED_REPLACED_MEM_ALLOCATOR = 0x00000100, /* memory allocator was replaced using LD_PRELOAD */
};
/* this is a bit field made of TAINTED_*, and is declared in haproxy.c */

1
include/haproxy/pool.h
View File

@ -101,7 +101,6 @@ extern int mem_poison_byte;
/* set of POOL_DBG_* flags */
extern uint pool_debugging;
int is_trim_enabled(void);
int malloc_trim(size_t pad);
void trim_all_pools(void);

10
src/pool.c
View File

@ -188,11 +188,6 @@ static void detect_allocator(void)
_malloc_trim = get_sym_next_addr("malloc_trim");
}
int is_trim_enabled(void)
{
return !disable_trim && using_default_allocator;
}
/* replace the libc's malloc_trim() so that we can also intercept the calls
* from child libraries when the allocator is not the default one.
*/
@ -1221,10 +1216,11 @@ INITCALL0(STG_PREPARE, init_pools);
/* Report in build options if trim is supported */
static void pools_register_build_options(void)
{
if (is_trim_enabled() && _malloc_trim) {
if (!using_default_allocator) {
char *ptr = NULL;
memprintf(&ptr, "Support for malloc_trim() is enabled.");
memprintf(&ptr, "Running with a replaced memory allocator (e.g. via LD_PRELOAD).");
hap_register_build_opts(ptr, 1);
mark_tainted(TAINTED_REPLACED_MEM_ALLOCATOR);
}
}
INITCALL0(STG_REGISTER, pools_register_build_options);