From 16147e6cf3b55cd1f6e75895d8268fc67a5c2b7d Mon Sep 17 00:00:00 2001 From: Amaury Denoyelle Date: Wed, 20 Nov 2024 11:09:35 +0100 Subject: [PATCH] BUG/MINOR: cfgparse-quic: fix renaming of max-window-size A patch has recently tried to rename QUIC max-window-size global parameter to default-max-window-size to better reflect its usage. However, only the documentation was edited but not cfgparse-quic.c. Fix this by updating cfgparse-quic.c with the new default- naming. No need to backport. --- src/cfgparse-quic.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cfgparse-quic.c b/src/cfgparse-quic.c index 0b1b4596d..8992bfb3d 100644 --- a/src/cfgparse-quic.c +++ b/src/cfgparse-quic.c @@ -347,14 +347,14 @@ static int cfg_parse_quic_tune_setting(char **args, int section_type, global.tune.quic_cubic_loss_tol = arg - 1; else if (strcmp(suffix, "frontend.conn-tx-buffers.limit") == 0) { memprintf(err, "'%s' keyword is now obsolote and has no effect. " - "Use 'tune.quic.frontend.max-window-size' to limit Tx buffer allocation per connection.", args[0]); + "Use 'tune.quic.frontend.default-max-window-size' to limit Tx buffer allocation per connection.", args[0]); return 1; } else if (strcmp(suffix, "frontend.glitches-threshold") == 0) global.tune.quic_frontend_glitches_threshold = arg; else if (strcmp(suffix, "frontend.max-streams-bidi") == 0) global.tune.quic_frontend_max_streams_bidi = arg; - else if (strcmp(suffix, "frontend.max-window-size") == 0) { + else if (strcmp(suffix, "frontend.default-max-window-size") == 0) { unsigned long cwnd; char *end_opt; @@ -457,7 +457,7 @@ static struct cfg_kw_list cfg_kws = {ILH, { { CFG_GLOBAL, "tune.quic.frontend.glitches-threshold", cfg_parse_quic_tune_setting }, { CFG_GLOBAL, "tune.quic.frontend.max-streams-bidi", cfg_parse_quic_tune_setting }, { CFG_GLOBAL, "tune.quic.frontend.max-idle-timeout", cfg_parse_quic_time }, - { CFG_GLOBAL, "tune.quic.frontend.max-window-size", cfg_parse_quic_tune_setting }, + { CFG_GLOBAL, "tune.quic.frontend.default-max-window-size", cfg_parse_quic_tune_setting }, { CFG_GLOBAL, "tune.quic.max-frame-loss", cfg_parse_quic_tune_setting }, { CFG_GLOBAL, "tune.quic.reorder-ratio", cfg_parse_quic_tune_setting }, { CFG_GLOBAL, "tune.quic.retry-threshold", cfg_parse_quic_tune_setting },