RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-05-08 10:48:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: connection: fix pool free regression with recent ppv2 TLV patches

Browse Source 
In commit fecc573da ("MEDIUM: connection: Generic, list-based allocation
and look-up of PPv2 TLVs") there was a tiny mistake, elements of length
<= 128 are allocated from pool_pp_128 but only those of length < 128 are
released to this pool, other ones go to pool_pp_256. Because of this,
elements of size exactly 128 are allocated from 128 and released to 256.
It can be reproduced a few times by running sample_fetches/tlvs.vtc 1000
times with -DDEBUG_DONT_SHARE_POOLS -DDEBUG_MEMORY_POOLS -DDEBUG_EXPR
-DDEBUG_STRICT=2 -DDEBUG_POOL_INTEGRITY -DDEBUG_POOL_TRACING
-DDEBUG_NO_POOLS. Not sure why it doesn't reproduce more often though.

No backport is needed. This should address github issues #2275 and #2274.
This commit is contained in:
Willy Tarreau 2023-09-04 11:45:37 +02:00
parent d52466726f
commit 135c66f6cb
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/connection.c
View File

@ -569,7 +569,7 @@ void conn_free(struct connection *conn)
LIST_DELETE(&tlv->list);
if (tlv->len > HA_PP2_TLV_VALUE_256)
free(tlv);
else if (tlv->len < HA_PP2_TLV_VALUE_128)
else if (tlv->len <= HA_PP2_TLV_VALUE_128)
pool_free(pool_head_pp_tlv_128, tlv);
else
pool_free(pool_head_pp_tlv_256, tlv);