RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-05-03 00:08:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR: mux-h2: always use h2_send() in h2_done_ff(), not h2_process()

Browse Source 
By calling h2_process(), the code would theoretically make it possible
for a synchronous ->wake() call to provoke an indirect call to h2_snd_buf()
while we're in h2_done_ff(), which could be quite bad. The current
conditions do not permit it right now but this could easily break by
accident. Better use h2_send() and wake the task up if needed. Precise
performance tests showed no change.
This commit is contained in:
Willy Tarreau 2023-11-04 08:12:17 +01:00
parent 58185669d8
commit 0fa5adee3b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/mux_h2.c
View File

@ -7070,7 +7070,8 @@ static void h2_done_ff(struct stconn *sc)
b_add(mbuf, 9); b_add(mbuf, 9);
h2s->sws -= sd->iobuf.data; h2s->sws -= sd->iobuf.data;
h2c->mws -= sd->iobuf.data; h2c->mws -= sd->iobuf.data;
h2_process(h2c); if (h2_send(h2s->h2c))
tasklet_wakeup(h2s->h2c->wait_event.tasklet);
end: end:
sd->iobuf.buf = NULL; sd->iobuf.buf = NULL;