RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-04-20 22:15:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: stconn: Wake applets on sending path if there is a pending shutdown

Browse Source 
An applet is not woken up on sending path if it is not waiting for data or
if it states it will not consume data. However, it is important to still
wake it up if there is a pending shutdown. Otherwise, the event may be
missed and some data may remain blocked in the channel's buffer.

Because of this bug, it is possible to have a stream stuck if data are also
blocked on the opposite channel. It is for instance possible to hit the buf
with the stats applet and a client not consuming data.

This patch must slowly be backported as far as 2.2. It should partially fix
issue #2249.
This commit is contained in:
Christopher Faulet 2023-09-01 13:55:42 +02:00
parent 9e394d34e0
commit 0b93ff8c87
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/stconn.c
View File

@ -958,8 +958,10 @@ static void sc_app_chk_snd_applet(struct stconn *sc)
if (unlikely(sc->state != SC_ST_EST || (sc->flags & SC_FL_SHUT_DONE))) if (unlikely(sc->state != SC_ST_EST || (sc->flags & SC_FL_SHUT_DONE)))
return; return;
/* we only wake the applet up if it was waiting for some data and is ready to consume it */ /* we only wake the applet up if it was waiting for some data and is ready to consume it
if (!sc_ep_test(sc, SE_FL_WAIT_DATA) || sc_ep_test(sc, SE_FL_WONT_CONSUME)) * or if there is a pending shutdown
*/
if (!sc_ep_test(sc, SE_FL_WAIT_DATA|SE_FL_WONT_CONSUME) && !(sc->flags & SC_FL_SHUT_WANTED))
return; return;
if (!channel_is_empty(oc)) { if (!channel_is_empty(oc)) {