RepoMirrors
/
haproxy
mirror of http://git.haproxy.org/git/haproxy.git/
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BUG/MEDIUM: resolvers: Really ignore trailing dot in domain names 

When a string is converted to a domain name label, the trailing dot must be
ignored. In resolv_str_to_dn_label(), there is a test to do so. However, the
trailing dot is not really ignored. The character itself is not copied but
the string index is still moved to the next char. Thus, this trailing dot is
counted in the length of the last encoded part of the domain name. Worst,
because the copy is skipped, a garbage character is included in the domain
name.

This patch should fix the issue #1528. It must be backported as far as 2.0.
This commit is contained in:
Christopher Faulet 2022-01-28 17:47:57 +01:00
parent 0442efd214
commit 0a82cf4c16
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/resolvers.c
View File

@ -1738,10 +1738,8 @@ int resolv_str_to_dn_label(const char *str, int str_len, char *dn, int dn_len)
return -1; return -1;
/* ignore trailing dot */ /* ignore trailing dot */
if (i + 1 == str_len) { if (i + 1 == str_len)
i++;
break; break;
}
dn[offset] = (i - offset); dn[offset] = (i - offset);
offset = i+1; offset = i+1;