RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2025-04-19 21:45:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

MINOR: stconn: Don't queue stream task in past in sc_notify()

Browse Source 
A task must never be queued in past. However, in sc_notify(), the stream
task, if not woken up, is queued. Thanks to previous fixes, the stream task
expiration date should be correct. But to prevent any issue, a BUG_ON() is
added to be sure it never happens. I guess a good idea could be to remove it
or change it to BUG_ON_HOT() for the final release.
This commit is contained in:
Christopher Faulet 2023-11-06 08:57:06 +01:00
parent 4a2660aa45
commit 08d7169f42
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/stconn.c
View File

@ -1146,6 +1146,8 @@ static void sc_notify(struct stconn *sc)
task->expire = tick_first(task->expire, oc->analyse_exp); task->expire = tick_first(task->expire, oc->analyse_exp);
task->expire = tick_first(task->expire, __sc_strm(sc)->conn_exp); task->expire = tick_first(task->expire, __sc_strm(sc)->conn_exp);
/* WARNING: Don't forget to remove this BUG_ON before 2.9.0 */
BUG_ON(tick_is_expired(task->expire, now_ms));
task_queue(task); task_queue(task);
} }