From 027d206b57bec59397eb6fb23f8ff4e3a2edb2e1 Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Thu, 23 Jan 2020 11:47:13 +0100 Subject: [PATCH] CLEANUP: stats: shut up a wrong null-deref warning from gcc 9.2 As reported in bug #447, gcc 9.2 invents impossible code paths and then complains that we don't check for our pointers to be NULL... This code path is not critical, better add the test to shut it up than try to help it being less creative. This code hasn't changed for a while, so it could help distros to backport this to older releases. --- src/stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/stats.c b/src/stats.c index 6330512ca..f8a15bd54 100644 --- a/src/stats.c +++ b/src/stats.c @@ -2411,7 +2411,7 @@ static void stats_dump_html_head(struct appctx *appctx, struct uri_auth *uri) "-->\n" "\n", (appctx->ctx.stats.flags & STAT_SHNODE) ? " on " : "", - (appctx->ctx.stats.flags & STAT_SHNODE) ? (uri->node ? uri->node : global.node) : "" + (appctx->ctx.stats.flags & STAT_SHNODE) ? (uri && uri->node ? uri->node : global.node) : "" ); }