haproxy/reg-tests/webstats/missing-stats-fields.vtc

varnishtest "Verifies the absence of (null) in 'show stats' header"

# This can happen if a new ST_I_PX_xxx enum is added without updating
# stats_fields[].

feature ignore_unknown_macro

haproxy h1 -conf {
} -start

haproxy h1 -cli {
    send "show stat"
    expect !~ (null)
}
MINOR: stats: protect against future stats fields omissions As seen in commits 33a4461fa ("BUG/MINOR: stats: Fix Lua's `get_stats` function") and a46b142e8 ("BUG/MINOR: Missing stat_field_names (since f21d17bb)") it seems frequent to omit to update stats_fields[] when adding a new ST_F_xxx entry. This breaks Lua's get_stats() and shows a "(null)" in the header of "show stat", but that one is not detectable to the naked eye anymore. Let's add a reminder above the enum declaration about this, and a small reg tests checking for the absence of "(null)". It was verified to fail before the last patch above. 2023-06-02 06:35:50 +00:00			`varnishtest "Verifies the absence of (null) in 'show stats' header"`

MINOR: stats: rename proxy stats This commit is the first one of a serie which adjust naming convention for stats module. The objective is to remove ambiguity and better reflect how stats are implemented, especially since the introduction of stats module. This patch renames elements related to proxies statistics. One of the main change is to rename ST_F_* statistics indexes prefix with the new name ST_I_PX_*. This remove the reference to field which represents another concept in the stats module. In the same vein, global stat_fields variable is renamed metrics_px. 2024-04-19 16:03:45 +00:00			`# This can happen if a new ST_I_PX_xxx enum is added without updating`
MINOR: stats: protect against future stats fields omissions As seen in commits 33a4461fa ("BUG/MINOR: stats: Fix Lua's `get_stats` function") and a46b142e8 ("BUG/MINOR: Missing stat_field_names (since f21d17bb)") it seems frequent to omit to update stats_fields[] when adding a new ST_F_xxx entry. This breaks Lua's get_stats() and shows a "(null)" in the header of "show stat", but that one is not detectable to the naked eye anymore. Let's add a reminder above the enum declaration about this, and a small reg tests checking for the absence of "(null)". It was verified to fail before the last patch above. 2023-06-02 06:35:50 +00:00			`# stats_fields[].`

			`feature ignore_unknown_macro`

			`haproxy h1 -conf {`
			`} -start`

			`haproxy h1 -cli {`
			`send "show stat"`
			`expect !~ (null)`
			`}`