RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2024-12-22 04:10:48 +00:00
Code Issues Packages Projects Releases Wiki Activity
e1465c1e46
haproxy/reg-tests/cache/expires.vtc

129 lines
3.5 KiB
Plaintext
Raw Normal View History

MINOR: cache: Add Expires header value parsing When no Cache-Control max-age or s-maxage information is present in a cached response, we need to parse the Expires header value (RFC 7234#5.3). An invalid Expires date value or a date earlier than the reception date will make the cache_entry stale upon creation. For now, the Cache-Control and Expires headers are parsed after the insertion of the response in the cache so even if the parsing of the Expires results in an already stale entry, the entry will exist in the cache.
2020-10-28 16:52:53 +00:00
varnishtest "Expires support"
#REQUIRE_VERSION=2.3
feature ignore_unknown_macro
server s1 {
rxreq
txresp -nolen -hdr "Transfer-Encoding: chunked" \
-hdr "Cache-Control: max-age=5"
chunkedlen 15
chunkedlen 15
chunkedlen 15
chunkedlen 0
} -start
server s2 {
rxreq
txresp -nolen -hdr "Transfer-Encoding: chunked"
chunkedlen 16
chunkedlen 16
chunkedlen 16
chunkedlen 0
} -start
server s3 {
rxreq
txresp -nolen -hdr "Transfer-Encoding: chunked"
chunkedlen 16
chunkedlen 16
chunkedlen 16
chunkedlen 0
rxreq
txresp -nolen -hdr "Transfer-Encoding: chunked"
chunkedlen 17
chunkedlen 17
chunkedlen 17
chunkedlen 0
} -start
haproxy h1 -conf {
REGTESTS: disable inter-thread idle connection sharing on sensitive tests Some regtests involve multiple requests from multiple clients, which can be dispatched as multiple requests to a server. It turns out that the idle connection sharing works so well that very quickly few connections are used, and regularly some of the remaining idle server connections time out at the moment they were going to be reused, causing those random "HTTP header incomplete" traces in the logs that make them fail often. In the end this is only an artefact of the test environment. And indeed, some tests like normalize-uri which perform a lot of reuse fail very often, about 20-30% of the times in the CI, and 100% of the time in local when running 1000 tests in a row. Others like ubase64, sample_fetches or vary_* fail less often but still a lot in tests. This patch addresses this by adding "tune.idle-pool.shared off" to all tests which have at least twice as many requests as clients. It proves very effective as no single error happens on normalize-uri anymore after 10000 tests. Also 100 full runs of all tests yield no error anymore. One test is tricky, http_abortonclose, it used to fail ~10 times per 1000 runs and with this workaround still fails once every 1000 runs. But the test is complex and there's a warning in it mentioning a possible issue when run in parallel due to a port reuse.
2021-05-09 12:41:41 +00:00
global
# WT: limit false-positives causing "HTTP header incomplete" due to
# idle server connections being randomly used and randomly expiring
# under us.
tune.idle-pool.shared off
MINOR: cache: Add Expires header value parsing When no Cache-Control max-age or s-maxage information is present in a cached response, we need to parse the Expires header value (RFC 7234#5.3). An invalid Expires date value or a date earlier than the reception date will make the cache_entry stale upon creation. For now, the Cache-Control and Expires headers are parsed after the insertion of the response in the cache so even if the parsing of the Expires results in an already stale entry, the entry will exist in the cache.
2020-10-28 16:52:53 +00:00
defaults
mode http
${no-htx} option http-use-htx
timeout connect 1s
timeout client 1s
timeout server 1s
frontend fe
bind "fd@${fe}"
use_backend cache_control_be if { path_beg /cache_control }
use_backend future_expires_be if { path_beg /future }
default_backend past_expires_be
backend cache_control_be
# Expires header should be ignored since a Cache-Control one is present
http-request cache-use my_cache
server www ${s1_addr}:${s1_port}
http-response set-header X-Cache-Hit %[res.cache_hit]
http-response set-header Expires %[date(-1),http_date]
http-response cache-store my_cache
backend future_expires_be
# Expires value set in the future (current_time+5s)
http-request cache-use my_cache
server www ${s2_addr}:${s2_port}
http-response set-header X-Cache-Hit %[res.cache_hit]
http-response set-header Expires %[date(5),http_date]
http-response cache-store my_cache
backend past_expires_be
# Expires value set in the past
http-request cache-use my_cache
server www ${s3_addr}:${s3_port}
http-response set-header X-Cache-Hit %[res.cache_hit]
http-response set-header Expires %[date(-1),http_date]
http-response cache-store my_cache
cache my_cache
total-max-size 3
max-age 20
max-object-size 3072
} -start
client c1 -connect ${h1_fe_sock} {
txreq -url "/cache_control"
rxresp
expect resp.status == 200
expect resp.bodylen == 45
txreq -url "/cache_control"
rxresp
expect resp.status == 200
expect resp.bodylen == 45
expect resp.http.X-Cache-Hit == 1
txreq -url "/future"
rxresp
expect resp.status == 200
expect resp.bodylen == 48
txreq -url "/future"
rxresp
expect resp.status == 200
expect resp.bodylen == 48
expect resp.http.X-Cache-Hit == 1
txreq -url "/past"
rxresp
expect resp.status == 200
expect resp.bodylen == 48
txreq -url "/past"
rxresp
expect resp.status == 200
expect resp.bodylen == 51
expect resp.http.X-Cache-Hit == 0
} -run
Reference in New Issue Copy Permalink