RepoMirrors/haproxy
1
0
Fork 0
mirror of http://git.haproxy.org/git/haproxy.git/ synced 2024-12-11 14:05:12 +00:00
Code Issues Packages Projects Releases Wiki Activity
2c897d9d1b
haproxy/reg-tests/seamless-reload/abns_socket.vtc

55 lines
1.6 KiB
Plaintext
Raw Normal View History

MINOR: reg-tests: Add a few regression testing files.
2018-06-20 05:26:44 +00:00
# commit b4dd15b
# BUG/MINOR: unix: Make sure we can transfer abns sockets on seamless reload.
#
# When checking if a socket we got from the parent is suitable for a listener,
# we just checked that the path matched sockname.tmp, however this is
# unsuitable for abns sockets, where we don't have to create a temporary
# file and rename it later.
# To detect that, check that the first character of the sun_path is 0 for
# both, and if so, that &sun_path[1] is the same too.
REGTESTS: mark abns_socket as working now William noticed that the real issue in the abns test was that it was failing to rebind some listeners, issues which were addressed in the previous commits (in some cases, the master would even accept traffic on the worker's socket which was not properly disabled, causing some of the strange error messages). The other issue documented in commit 2ea15a080 was the lack of reliability when the test was run in parallel. This is caused by the abns socket which uses a hard-coded address, making all tests in parallel to step onto each others' toes. Since vtest cannot provide abns sockets, we're instead concatenating the number of the listening port that vtest allocated for another frontend to the abns path, which guarantees to make them unique in the system. The test works fine in all cases now, even with 100 in parallel.
2020-11-03 17:43:48 +00:00
#
# Note: there are some tricks here. One of them is that we must not bind the
# same abns address to multiple processes that may run in parallel. Since
# vtest cannot provide abns sockets, we're instead concatenating the number
# of the listening port that vtest allocated for another frontend to the abns
# path, which guarantees to make them unique in the system.
MINOR: reg-tests: Add a few regression testing files.
2018-06-20 05:26:44 +00:00
varnishtest "Seamless reload issue with abns sockets"
feature ignore_unknown_macro
REGTEST/MINOR: skip seamless-reload test with abns socket on freebsd abns sockets are not available on freebsd as such mark the test to skip this OS and expose-fd was implemented first in 1.8 so require that
2018-12-08 19:51:16 +00:00
# abns@ sockets are not available on freebsd
REGTEST: exclude OSX and generic targets from abns_socket.vtc This one relies on Linux's abstract namespace sockets which are not available there. FreeBSD used to already be excluded.
2019-04-25 06:50:25 +00:00
#EXCLUDE_TARGETS=freebsd,osx,generic
REGTEST: make abns_socket.vtc require 1.8 It's not as much an abns test as it is a seamless reload test, which appeared in 1.8 due to "expose-fd listeners".
2020-09-29 08:58:44 +00:00
#REQUIRE_VERSION=1.8
REGTESTS: mark the abns test as broken again There is apparently a race in this test that would require relying on haproxy's output to make it reliably work, but currently vtest doesn't have this option. Let's mark it broken again to avoid polluting the CI. This is discussed in github issue #950.
2020-11-17 10:45:10 +00:00
#REGTEST_TYPE=broken
REGTEST/MINOR: skip seamless-reload test with abns socket on freebsd abns sockets are not available on freebsd as such mark the test to skip this OS and expose-fd was implemented first in 1.8 so require that
2018-12-08 19:51:16 +00:00
MINOR: reg-tests: Add a few regression testing files.
2018-06-20 05:26:44 +00:00
haproxy h1 -W -conf {
global
REGTEST: Missing enclosing quotes for ${tmpdir} macro.
2018-12-20 08:55:44 +00:00
stats socket "${tmpdir}/h1/stats" level admin expose-fd listeners
MINOR: reg-tests: Add a few regression testing files.
2018-06-20 05:26:44 +00:00
defaults
mode http
log global
option httplog
REGTEST: increase timeouts on the seamless-reload test The abns_socket in seamless-reload regtest regularly fails in Travis-CI on smaller machines only (typically the ppc64le and sometimes s390x). The error always reports an incomplete HTTP header as seen from the client. And this can occasionally be reproduced on the minicloud ppc64le image when setting a huge file descriptors limit (1 million). What happens in fact is the following: depending on the binding order, some connections from the client might reach the TCP listener on the old instance and be forwarded to the ABNS listener of the second instance just being prepared to start up. But due to the huge number of FDs, setting them up takes slightly more time and the 20ms server timeout may expire before the new instance finishes its startup. This can result in an occasional 504, except that since the client timeout is the same as the server timeout, both sides are closed at the same time and the client doesn't receive the 504. In addition a second problem plugs onto this: by default http-reuse is enabled. Some requests being forwarded to the older instance will be sent over an already established connection. But the CPU used by the starting process using many FDs will be taken away from the older process, whose abns listener will not see a request for more than 20ms, and will decide to kill the idle client connection. At the same moment the TCP proxy forwards a request over this closing connection, it detects the close and silently closes the other side to let the client retry, which is detected by the vtest client as another case of empty header. This is easier to reproduce in VMs with few CPUs (2 or less) and some noisy neighbors such as a few spinning loops in background. Let's just increase this tests' timeout to avoid this. While a few ms are close to the scheduler's granularity, this test is never supposed to trigger the timeouts so it's safe to go higher without impacts on the test execution time. At one second the problem seems impossible to reproduce on the minicloud VMs.
2020-03-23 08:11:51 +00:00
timeout connect 1s
timeout client 1s
timeout server 1s
MINOR: reg-tests: Add a few regression testing files.
2018-06-20 05:26:44 +00:00
listen testme
bind "fd@${testme}"
REGTESTS: mark abns_socket as working now William noticed that the real issue in the abns test was that it was failing to rebind some listeners, issues which were addressed in the previous commits (in some cases, the master would even accept traffic on the worker's socket which was not properly disabled, causing some of the strange error messages). The other issue documented in commit 2ea15a080 was the lack of reliability when the test was run in parallel. This is caused by the abns socket which uses a hard-coded address, making all tests in parallel to step onto each others' toes. Since vtest cannot provide abns sockets, we're instead concatenating the number of the listening port that vtest allocated for another frontend to the abns path, which guarantees to make them unique in the system. The test works fine in all cases now, even with 100 in parallel.
2020-11-03 17:43:48 +00:00
server test_abns_server abns@wpproc1_${h1_testme_port} send-proxy-v2
MINOR: reg-tests: Add a few regression testing files.
2018-06-20 05:26:44 +00:00
frontend test_abns
REGTESTS: mark abns_socket as working now William noticed that the real issue in the abns test was that it was failing to rebind some listeners, issues which were addressed in the previous commits (in some cases, the master would even accept traffic on the worker's socket which was not properly disabled, causing some of the strange error messages). The other issue documented in commit 2ea15a080 was the lack of reliability when the test was run in parallel. This is caused by the abns socket which uses a hard-coded address, making all tests in parallel to step onto each others' toes. Since vtest cannot provide abns sockets, we're instead concatenating the number of the listening port that vtest allocated for another frontend to the abns path, which guarantees to make them unique in the system. The test works fine in all cases now, even with 100 in parallel.
2020-11-03 17:43:48 +00:00
bind abns@wpproc1_${h1_testme_port} accept-proxy
MINOR: reg-tests: Add a few regression testing files.
2018-06-20 05:26:44 +00:00
http-request deny deny_status 200
} -start
shell {
REGTEST: Missing enclosing quotes for ${tmpdir} macro.
2018-12-20 08:55:44 +00:00
kill -USR2 $(cat "${tmpdir}/h1/pid")
MINOR: reg-tests: Add a few regression testing files.
2018-06-20 05:26:44 +00:00
}
client c1 -connect ${h1_testme_sock} {
txreq -url "/"
rxresp
} -repeat 50 -run
Reference in New Issue Copy Permalink