RepoMirrors
/
haproxy
mirror of http://git.haproxy.org/git/haproxy.git/
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
haproxy/reg-tests/log/wrong_ip_port_logging.vtc

63 lines
2.0 KiB
Plaintext
Raw Normal View History

MINOR: reg-tests: Add a few regression testing files.
2018-06-20 05:26:44 +00:00
# commit d02286d
# BUG/MINOR: log: pin the front connection when front ip/ports are logged
#
# Mathias Weiersmueller reported an interesting issue with logs which Lukas
# diagnosed as dating back from commit 9b061e332 (1.5-dev9). When front
# connection information (ip, port) are logged in TCP mode and the log is
# emitted at the end of the connection (eg: because %B or any log tag
# requiring LW_BYTES is set), the log is emitted after the connection is
# closed, so the address and ports cannot be retrieved anymore.
#
CLEANUP: fix typos in reg-tests Fix typos in comments and error messages of reg-tests. Note that this has not been qualified as minor as it is used for testing purposes, not end-users.
2018-11-14 04:15:49 +00:00
# It could be argued that we'd make a special case of these to immediately
MINOR: reg-tests: Add a few regression testing files.
2018-06-20 05:26:44 +00:00
# retrieve the source and destination addresses from the connection, but it
# seems cleaner to simply pin the front connection, marking it "tracked" by
# adding the LW_XPRT flag to mention that we'll need some of these elements
# at the last moment. Only LW_FRTIP and LW_CLIP are affected. Note that after
# this change, LW_FRTIP could simply be removed as it's not used anywhere.
#
# Note that the problem doesn't happen when using %[src] or %[dst] since
# all sample expressions set LW_XPRT.
REGTEST: replace LEVEL option by a more human readable one. This patch replaces LEVEL variable by REGTESTS_TYPES variable which is more mnemonic and human readable. It is uses as a filter to run the reg tests scripts where a commented #REGTEST_TYPE may be defined to designate their types. Running the following command: $ REGTESTS_TYPES=slow,default will start all the reg tests where REGTEST_TYPE is defines as 'slow' or 'default'. Note that 'default' is also the default value of REGTEST_TYPE when not specified dedicated to run all the current h*.vtc files. When REGTESTS_TYPES is not specified there is no filter at all. All the tests are run. This patches also defines REGTEST_TYPE with 'slow' value for all the s*.vtc files, 'bug' value for al the b*.vtc files, 'broken' value for all the k*.vtc files.
2019-03-29 14:07:24 +00:00
#REGTEST_TYPE=bug
MINOR: reg-tests: Add a few regression testing files.
2018-06-20 05:26:44 +00:00
varnishtest "Wrong ip/port logging"
feature ignore_unknown_macro
server s1 {
rxreq
REGTEST: log/b00000: Be sure the client always hits its timeout To do so, the server does not send anything. Instead it waits 2ms before closing. The client, on its side, will wait for a response. So it will be blocked. Becauase the client timeout is set to 1ms, HAProxy should always close the client connection because it times out.
2019-04-01 13:33:19 +00:00
delay 0.02
MINOR: reg-tests: Add a few regression testing files.
2018-06-20 05:26:44 +00:00
} -start
syslog Slg_1 -level notice {
recv info
REGTEST: make the IP+port logging test more reliable On my machine, test log/b00000.vtc fails ~9/10 times. Apparently, the connection is often marked as reset before the timeout strikes, so the log shows "CD" flags instead of "cD". This fix does two things : 1) shorten the client timeout to 1 millisecond instead of 5 2) accept both "cD" and "CD" as valid termination states since the purpose is to validate the source address and port, and not the status itself.
2018-10-28 18:19:48 +00:00
expect ~ \"dip\":\"${h1_fe_1_addr}\",\"dport\":\"${h1_fe_1_port}.*\"ts\":\"[cC]D\",\"
MINOR: reg-tests: Add a few regression testing files.
2018-06-20 05:26:44 +00:00
} -start
haproxy h1 -conf {
global
log ${Slg_1_addr}:${Slg_1_port} local0
defaults
log global
REGTESTS: extend the default I/O timeouts and make them overridable With the CI occasionally slowing down, we're starting to see again some spurious failures despite the long 1-second timeouts. This reports false positives that are disturbing and doesn't provide as much value as this could. However at this delay it already becomes a pain for developers to wait for the tests to complete. This commit adds support for the new environment variable HAPROXY_TEST_TIMEOUT that will allow anyone to modify the connect, client and server timeouts. It was set to 5 seconds by default, which should be plenty for quite some time in the CI. All relevant values that were 200ms or above were replaced by this one. A few larger values were left as they are special. One test for the set-timeout action that used to rely on a fixed 1-sec value was extended to a fixed 5-sec, as the timeout is normally not reached, but it needs to be known to compare the old and new values.
2021-11-18 16:46:22 +00:00
timeout connect "${HAPROXY_TEST_TIMEOUT-5s}"
REGTEST: make the IP+port logging test more reliable On my machine, test log/b00000.vtc fails ~9/10 times. Apparently, the connection is often marked as reset before the timeout strikes, so the log shows "CD" flags instead of "cD". This fix does two things : 1) shorten the client timeout to 1 millisecond instead of 5 2) accept both "cD" and "CD" as valid termination states since the purpose is to validate the source address and port, and not the status itself.
2018-10-28 18:19:48 +00:00
timeout client 1
REGTESTS: extend the default I/O timeouts and make them overridable With the CI occasionally slowing down, we're starting to see again some spurious failures despite the long 1-second timeouts. This reports false positives that are disturbing and doesn't provide as much value as this could. However at this delay it already becomes a pain for developers to wait for the tests to complete. This commit adds support for the new environment variable HAPROXY_TEST_TIMEOUT that will allow anyone to modify the connect, client and server timeouts. It was set to 5 seconds by default, which should be plenty for quite some time in the CI. All relevant values that were 200ms or above were replaced by this one. A few larger values were left as they are special. One test for the set-timeout action that used to rely on a fixed 1-sec value was extended to a fixed 5-sec, as the timeout is normally not reached, but it needs to be known to compare the old and new values.
2021-11-18 16:46:22 +00:00
timeout server "${HAPROXY_TEST_TIMEOUT-5s}"
MINOR: reg-tests: Add a few regression testing files.
2018-06-20 05:26:44 +00:00
frontend fe1
bind "fd@${fe_1}"
mode tcp
log-format {\"dip\":\"%fi\",\"dport\":\"%fp\",\"c_ip\":\"%ci\",\"c_port\":\"%cp\",\"fe_name\":\"%ft\",\"be_name\":\"%b\",\"s_name\":\"%s\",\"ts\":\"%ts\",\"bytes_read\":\"%B\"}
default_backend be_app
backend be_app
REGTEST/MINOR: remove health-check that can make the test fail The reg-tests/log/b00000.vtc should not try to perform a health-check of server s1 as it only allows 1 request/connection
2018-12-08 20:36:55 +00:00
server app1 ${s1_addr}:${s1_port}
MINOR: reg-tests: Add a few regression testing files.
2018-06-20 05:26:44 +00:00
} -start
client c1 -connect ${h1_fe_1_sock} {
txreq -url "/"
REGTEST: Wrong assumption in IP:port logging test. In this reg test, as the client connection is not supposed to receive any server response, we should try to "rxresp" but we should expect the client connection to be closed by haproxy. This is done replacing "rxresp" by "expect_close". Furthermore since dbb75ee3 vtest commit, calling "rxresp" expects at least to receive a HTTP header as shown by Travis build here: https://travis-ci.com/haproxy/haproxy/jobs/198126488.
2019-05-07 10:00:36 +00:00
expect_close
MINOR: reg-tests: Add a few regression testing files.
2018-06-20 05:26:44 +00:00
} -run
syslog Slg_1 -wait