mirror of
https://github.com/gperftools/gperftools
synced 2024-12-21 06:50:03 +00:00
8be84e4a5c
Previous implementation wasn't entirely safe w.r.t. 32-bit off_t systems. Specifically around mmap replacement hook. Also, API was a lot more general and broad than we actually need. Sadly, old mmap hooks API was shipped with our public headers. But thankfully it appears to be unused externally (checked via github search). So we keep this old API and ABI for the sake of formal API and ABI compatibility. But this old API is now empty and always fails (some OS/hardware combinations didn't have functional implementations of those hooks anyways). New API is 64-bit clean and only provides us with what we need. Namely being able to react to virtual address space mapping changes for logging, heap profiling and heap leak checker. I.e. no pre hooks or mmap-replacement hooks. We also explicitly not ship this API externally to give us freedom to change it. New code is also hopefully tidier and slightly more portable. At least there are fewer arch-specific ifdef-s. Another somewhat notable change is, since mmap hook isn't needed in "minimal" configuration, we now don't override system's mmap/munmap/etc functions in this configuration. No big deal, but it reduces risk of damage if we somehow mess those up. I.e. musl's mmap does few things that our mmap replacement doesn't, such as very fancy vm_lock thingy. Which doesn't look critical, but is good thing for us not to interfere with when not necessary. Fixes issue #1406 and issue #1407. Lets also mention issue #1010 which is somewhat relevant. |
||
|---|---|---|
| .. | ||
| addr2line-pdb | ||
| addressmap_unittest | ||
| current_allocated_bytes_test | ||
| frag_unittest | ||
| libtcmalloc_minimal | ||
| low_level_alloc_unittest | ||
| malloc_extension_test | ||
| malloc_hook_test | ||
| markidle_unittest | ||
| nm-pdb | ||
| packed-cache_test | ||
| page_heap_test | ||
| pagemap_unittest | ||
| preamble_patcher_test | ||
| realloc_unittest | ||
| sampler_test | ||
| stack_trace_table_test | ||
| system-alloc_unittest | ||
| tcmalloc_minimal_large | ||
| tcmalloc_minimal_unittest | ||
| thread_dealloc_unittest | ||