update comment for fixed fork testing of ManyThreads

This commit is contained in:
Aliaksei Kandratsenka 2024-10-15 20:58:26 -04:00
parent 8f74e39c00
commit e9fbbf9450
1 changed files with 4 additions and 7 deletions

View File

@ -2115,13 +2115,10 @@ tcmalloc::Cleanup<std::function<void()>> setup_fork_testing(int* argc, char ***
// EFLAGS to single-step. // EFLAGS to single-step.
raise(SIGTRAP); raise(SIGTRAP);
// This is a flag for a couple of tests that are not compatible with // This is a flag for a test that is not compatible with
// single-stepping. a) ManyThreads tests doesn't work because // single-stepping. NewHandler test doesn't work because it enables
// pthread creation code blocks all signals at some point and which // oom simulation at some point which, naturally, crashes the forked
// crashes the process, because kernel has no way of delivering // child.
// synchronous SIGRAP b) NewHandler test doesn't work because it
// enables oom simulation at some point which, naturally, crashes
// the forked child.
running_fork_testing = true; running_fork_testing = true;
return tcmalloc::Cleanup(std::function<void()>([] () { return tcmalloc::Cleanup(std::function<void()>([] () {