RepoMirrors
/
gperftools
mirror of https://github.com/gperftools/gperftools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

removed extra barriers in malloc hooks mutation methods 

Because those are already done under spinlock and read-only and
lockless Traverse is already tolerant to slight inconsistencies.
This commit is contained in:
Aliaksey Kandratsenka 2014-11-09 16:13:54 -08:00
parent 890f34c77e
commit ba0441785b
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/malloc_hook.cc
View File

@ -207,9 +207,9 @@ bool HookList<T>::Add(T value_as_t) {
return false; return false;
} }
AtomicWord prev_num_hooks = base::subtle::Acquire_Load(&priv_end); AtomicWord prev_num_hooks = base::subtle::Acquire_Load(&priv_end);
base::subtle::Release_Store(&priv_data[index], value); base::subtle::NoBarrier_Store(&priv_data[index], value);
if (prev_num_hooks <= index) { if (prev_num_hooks <= index) {
base::subtle::Release_Store(&priv_end, index + 1); base::subtle::NoBarrier_Store(&priv_end, index + 1);
} }
return true; return true;
} }
@ -230,16 +230,16 @@ bool HookList<T>::Remove(T value_as_t) {
return false; return false;
} }
SpinLockHolder l(&hooklist_spinlock); SpinLockHolder l(&hooklist_spinlock);
AtomicWord hooks_end = base::subtle::Acquire_Load(&priv_end); AtomicWord hooks_end = base::subtle::NoBarrier_Load(&priv_end);
int index = 0; int index = 0;
while (index < hooks_end && value_as_t != bit_cast<T>( while (index < hooks_end && value_as_t != bit_cast<T>(
base::subtle::Acquire_Load(&priv_data[index]))) { base::subtle::NoBarrier_Load(&priv_data[index]))) {
++index; ++index;
} }
if (index == hooks_end) { if (index == hooks_end) {
return false; return false;
} }
base::subtle::Release_Store(&priv_data[index], 0); base::subtle::NoBarrier_Store(&priv_data[index], 0);
FixupPrivEndLocked(); FixupPrivEndLocked();
return true; return true;
} }