From b569be106c01e3814dafee57b619874c04cefda0 Mon Sep 17 00:00:00 2001 From: Aliaksei Kandratsenka Date: Wed, 25 Sep 2024 17:32:46 -0400 Subject: [PATCH] [stacktrace_unittest] skip "from ucontext" case when not on glibc glibc carefully handles unwind info for signal trampoline stack frame, so even brittle "skip N frames" case works there. But e.g. on musl it doesn't. So lets skip this test on non-glibc systemsfor now, until we test things closer to how it is done by cpu profiler. --- src/tests/stacktrace_unittest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tests/stacktrace_unittest.cc b/src/tests/stacktrace_unittest.cc index 52805b3..6e821af 100644 --- a/src/tests/stacktrace_unittest.cc +++ b/src/tests/stacktrace_unittest.cc @@ -373,7 +373,7 @@ void RunTest() { #if TEST_UCONTEXT_BITS bool want_to_test = !skipping_ucontext; -#if !__linux__ +#if !__linux__ || !defined(__GLIBC__) // Our current "with ucontext" backtracing relies on fixed number of // stack frames to skip. Which is brittle and actually fails on // e.g. BSDs. There is a notable exception of generic_fp