RepoMirrors/gperftools
1
0
Fork 0
mirror of https://github.com/gperftools/gperftools synced 2025-02-16 11:47:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix spurious rare failures in profile handler unittest

Browse Source 
It's method of verifying that cpu profiling ticks happens is
inherently brittle. It sleeps certain time and then checks if ticks
happened during that time. And sleeping is by wall clock time. But due
to cpu scheduling being unpredictable, it is not impossible to see no
ticks even waiting 200 ms. We improve the issue by having the code
loop a bit until it seeks ticks happen.
This commit is contained in:
Aliaksey Kandratsenka 2024-08-18 15:52:59 -04:00
parent 2e0b81852e
commit ae15d7a490
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/tests/profile-handler_unittest.cc
View File

@ -272,10 +272,21 @@ class ProfileHandlerTest : public ::testing::Test {
uint64_t interrupts_before = GetInterruptCount();
// Sleep for a bit and check that tick counter is making progress.
int old_tick_count = tick_counter;
int new_tick_count;
uint64_t interrupts_after;
Delay(kSleepInterval);
int new_tick_count = tick_counter;
uint64_t interrupts_after = GetInterruptCount();
if (FLAGS_test_profiler_enabled) {
// The "sleep" check we do here is somewhat inherently
// brittle. But we can repeat waiting a bit more to ensure that
// ticks do occur.
for (int i = 10; i > 0; i--) {
new_tick_count = tick_counter;
interrupts_after = GetInterruptCount();
if (new_tick_count > old_tick_count && interrupts_after > interrupts_before) {
break;
}
Delay(kSleepInterval);
}
EXPECT_GT(new_tick_count, old_tick_count);
EXPECT_GT(interrupts_after, interrupts_before);
} else {