RepoMirrors
/
gperftools
mirror of https://github.com/gperftools/gperftools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

avoid testing known-to-fail cases of backtracing from ucontext 

See https://github.com/gperftools/gperftools/issues/1524
This commit is contained in:
Aliaksey Kandratsenka 2024-06-12 15:44:03 -04:00
parent 5284f386ee
commit 7c736310f9
1 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/tests/stacktrace_unittest.cc
View File

@ -66,6 +66,8 @@
// backtrace. // backtrace.
const int BACKTRACE_STEPS = 6; const int BACKTRACE_STEPS = 6;
static const char* tested_implementation_name;
struct AddressRange { struct AddressRange {
const void *start, *end; const void *start, *end;
}; };
@ -363,7 +365,19 @@ void RunTest() {
printf("PASS\n"); printf("PASS\n");
#if TEST_UCONTEXT_BITS #if TEST_UCONTEXT_BITS
if (!skipping_ucontext) { bool want_to_test = !skipping_ucontext;
#if !__linux__
// Our current "with ucontext" backtracing relies on fixed number of
// stack frames to skip. Which is brittle and actually fails on
// e.g. BSDs. There is a notable exception of generic_fp
// backtracer. Which, if exists, is actually doing backtracing from
// given ucontext parameter. So on Linux we test all implementations
// (which passes in practice at least on platforms I test), and
// everyone else only does ucontext tests with generic_fp method.
std::string name = tested_implementation_name;
want_to_test = want_to_test && (name == "generic_fp" || name == "generic_fp_unsafe");
#endif // !__linux__
if (want_to_test) {
leaf_capture_fn = CaptureLeafUContext; leaf_capture_fn = CaptureLeafUContext;
CheckStackTrace(0); CheckStackTrace(0);
printf("PASS\n"); printf("PASS\n");
@ -384,11 +398,11 @@ int main(int argc, char** argv) {
for (;;) { for (;;) {
// first arg if given is stacktrace implementation we want to test // first arg if given is stacktrace implementation we want to test
const char* name = TEST_bump_stacktrace_implementation((argc > 1) ? argv[1] : nullptr); tested_implementation_name = TEST_bump_stacktrace_implementation((argc > 1) ? argv[1] : nullptr);
if (!name) { if (!tested_implementation_name) {
break; break;
} }
printf("Testing stacktrace implementation: %s\n", name); printf("\n-----\nTesting stacktrace implementation: %s\n", tested_implementation_name);
leaf_capture_len = 20; leaf_capture_len = 20;
RunTest(); RunTest();