RepoMirrors/gperftools
1
0
Fork 0
mirror of https://github.com/gperftools/gperftools synced 2025-02-20 14:16:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

issue-506: fixed bogus unit test failure

Browse Source 
Looks like my version of GCC is aware that free(malloc(X)) is a
no-op. So it optimizes that away completely ignoring simple fact that
we're observing malloc hooks invocations. By adding check that malloc
succeeded we force gcc to actually preserve that malloc call.



git-svn-id: http://gperftools.googlecode.com/svn/trunk@208 6b5cf1ce-ec42-a296-1ba9-69fdba395a50
This commit is contained in:
alkondratenko@gmail.com 2013-03-11 19:24:49 +00:00
parent 7896dcb9db
commit 6354e2c8cd
1 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/tests/malloc_extension_c_test.c
View File

@ -59,6 +59,16 @@ void TestDeleteHook(const void* ptr) {
g_delete_hook_calls++;
}
static
void *forced_malloc(size_t size)
{
void *rv = malloc(size);
if (!rv) {
FAIL("malloc is not supposed to fail here");
}
return rv;
}
void TestMallocHook(void) {
/* TODO(csilvers): figure out why we get:
* E0100 00:00:00.000000 7383 malloc_hook.cc:244] RAW: google_malloc section is missing, thus InHookCaller is broken!
@ -78,8 +88,9 @@ void TestMallocHook(void) {
if (!MallocHook_AddDeleteHook(&TestDeleteHook)) {
FAIL("Failed to add delete hook");
}
free(malloc(10));
free(malloc(20));
free(forced_malloc(10));
free(forced_malloc(20));
if (g_new_hook_calls != 2) {
FAIL("Wrong number of calls to the new hook");
}