From 49dbe4362b431629111b85929d91fe9a46c42295 Mon Sep 17 00:00:00 2001 From: Aliaksey Kandratsenka Date: Mon, 3 Sep 2018 16:44:52 -0700 Subject: [PATCH] Add comment about gperftools 2.8 not deduplicating heapz samples. --- src/gperftools/malloc_extension.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/gperftools/malloc_extension.h b/src/gperftools/malloc_extension.h index 689b5f1..1800266 100644 --- a/src/gperftools/malloc_extension.h +++ b/src/gperftools/malloc_extension.h @@ -123,6 +123,10 @@ class PERFTOOLS_DLL_DECL MallocExtension { // therefore be passed to "pprof". This function is equivalent to // ReadStackTraces. The main difference is that this function returns // serialized data appropriately formatted for use by the pprof tool. + // + // Since gperftools 2.8 heap samples are not de-duplicated by the + // library anymore. + // // NOTE: by default, tcmalloc does not do any heap sampling, and this // function will always return an empty sample. To get useful // data from GetHeapSample, you must also set the environment