mirror of
https://github.com/ceph/go-ceph
synced 2024-12-25 23:52:27 +00:00
09b6977dc9
Release resources that are allocated while configuring the connection to the cluster. rados_shutdown() should only be needed after a successful call to rados_connect(), however if the connection has been configured with non-default parameters, some of the parameters may be allocated before connecting. rados_shutdown() will free the allocated resources, even if there has not been a connection yet. Note that the finalizers get executed during garbage collection, which can be forced by calling runtime.GC() for testing. Fixes: #109 Signed-off-by: Niels de Vos <ndevos@redhat.com>
47 lines
964 B
Go
47 lines
964 B
Go
// issue-109.go: analyze memory leak when rados.Conn.Connect() fails.
|
|
//
|
|
// build with: go build issue-109.go
|
|
// test with: valgrind ./issue-109
|
|
|
|
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"runtime"
|
|
"time"
|
|
|
|
"github.com/ceph/go-ceph/rados"
|
|
)
|
|
|
|
func main() {
|
|
for i := 1; i <= 100; i++ {
|
|
c, err := getConnection("127.0.0.1", "nobody", "secret")
|
|
if err != nil {
|
|
fmt.Printf("getConnection failed: %v\n", err)
|
|
} else {
|
|
c.Shutdown()
|
|
}
|
|
}
|
|
|
|
// force running the garbage collector
|
|
runtime.GC()
|
|
time.Sleep(time.Second)
|
|
}
|
|
|
|
func getConnection(monitors, user, key string) (*rados.Conn, error) {
|
|
conn, err := rados.NewConnWithUser(user)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
args := []string{"--client_mount_timeout", "15", "-m", monitors, "--key", key}
|
|
err = conn.ParseCmdLineArgs(args)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("ParseCmdLineArgs: %v", err)
|
|
}
|
|
err = conn.Connect()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("Connect: %v", err)
|
|
}
|
|
return conn, nil
|
|
}
|