From fb7c0f65611e32e19e65264ca9bafe3831bfacb5 Mon Sep 17 00:00:00 2001 From: John Mulligan Date: Fri, 8 May 2020 10:34:34 -0400 Subject: [PATCH] implements: renamed "covered" to "found" To be clearer about what the tool detects, rename "covered" to "found" such as not to indicate an undocumented but used function is considered "covered". Future arguments about what "covered" really means to be scheduled at a later date. :-) Signed-off-by: John Mulligan --- contrib/implements/internal/implements/json_report.go | 4 ++-- contrib/implements/internal/implements/report.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/implements/internal/implements/json_report.go b/contrib/implements/internal/implements/json_report.go index 76843e9..ce058d2 100644 --- a/contrib/implements/internal/implements/json_report.go +++ b/contrib/implements/internal/implements/json_report.go @@ -47,7 +47,7 @@ type jrPackage struct { Missing int `json:"missing"` Deprecated int `json:"deprecated"` } `json:"summary"` - Covered []jrFunction `json:"covered,omitempty"` + Found []jrFunction `json:"found,omitempty"` Missing []jrFunction `json:"missing,omitempty"` } @@ -90,7 +90,7 @@ func collectFuncs(jp *jrPackage, ii *Inspector) { if n := ii.visitor.docMap[cf.Name]; n != "" { refm[n] = true } - jp.Covered = append(jp.Covered, + jp.Found = append(jp.Found, jrFunction{cf.Name, jrFlags(flags), mkeys(refm)}) } } diff --git a/contrib/implements/internal/implements/report.go b/contrib/implements/internal/implements/report.go index 749fa0c..bd80912 100644 --- a/contrib/implements/internal/implements/report.go +++ b/contrib/implements/internal/implements/report.go @@ -78,7 +78,7 @@ func (r *TextReport) Report(name string, ii *Inspector) error { tags = " (" + strings.TrimSpace(tags) + ")" } } - fmt.Printf(" Covered: %s%s\n", cf.Name, tags) + fmt.Printf(" Found: %s%s\n", cf.Name, tags) } } for _, cf := range ii.expected {