RepoMirrors/go-ceph
1
0
Fork 0
mirror of https://github.com/ceph/go-ceph synced 2024-12-24 07:03:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

rbd: use uuid library, rather than shelling out, in rbd test

Browse Source 
Previously, the tests were shelling out to run 'uuidgen' which
is not particularly efficient and a bit ugly. Switch this test
to use the same uuid library already in use by the rados test code.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
This commit is contained in:
John Mulligan 2019-10-31 11:43:08 -04:00 committed by John Mulligan
parent 472f6dd5bb
commit fa319f99bb
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
rbd/rbd_test.go
View File

@ -3,13 +3,13 @@ package rbd_test
import (
"bytes"
"encoding/json"
"os/exec"
"sort"
"testing"
"time"
"github.com/ceph/go-ceph/rados"
"github.com/ceph/go-ceph/rbd"
"github.com/gofrs/uuid"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)
@ -19,8 +19,7 @@ var RbdFeatureLayering = uint64(1 << 0)
var RbdFeatureStripingV2 = uint64(1 << 1)
func GetUUID() string {
out, _ := exec.Command("uuidgen").Output()
return string(out[:36])
return uuid.Must(uuid.NewV4()).String()
}
func TestVersion(t *testing.T) {