RepoMirrors
/
go-ceph
mirror of https://github.com/ceph/go-ceph
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rbd: add well-formed doc comments to the rbd snapshot functions. 

No functionality change, just comments.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
This commit is contained in:
John Mulligan 2020-02-25 12:20:58 -05:00 committed by Niels de Vos
parent 4fc730ad39
commit d9ce9ad799
1 changed files with 33 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
rbd/snapshot.go
View File

@ -9,13 +9,17 @@ import (
"unsafe" "unsafe"
) )
// // Snapshot represents a snapshot on a particular rbd image.
type Snapshot struct { type Snapshot struct {
image *Image image *Image
name string name string
} }
// int rbd_snap_create(rbd_image_t image, const char *snapname); // CreateSnapshot returns a new Snapshot objects after creating
// a snapshot of the rbd image.
//
// Implements:
// int rbd_snap_create(rbd_image_t image, const char *snapname);
func (image *Image) CreateSnapshot(snapname string) (*Snapshot, error) { func (image *Image) CreateSnapshot(snapname string) (*Snapshot, error) {
if err := image.validate(imageIsOpen); err != nil { if err := image.validate(imageIsOpen); err != nil {
return nil, err return nil, err
@ -48,7 +52,8 @@ func (snapshot *Snapshot) validate(req uint32) error {
return nil return nil
} }
// // GetSnapshot constructs a snapshot object for the image given
// the snap name. It does not validate that this snapshot exists.
func (image *Image) GetSnapshot(snapname string) *Snapshot { func (image *Image) GetSnapshot(snapname string) *Snapshot {
return &Snapshot{ return &Snapshot{
image: image, image: image,
@ -56,7 +61,10 @@ func (image *Image) GetSnapshot(snapname string) *Snapshot {
} }
} }
// int rbd_snap_remove(rbd_image_t image, const char *snapname); // Remove the snapshot from the connected rbd image.
//
// Implements:
// int rbd_snap_remove(rbd_image_t image, const char *snapname);
func (snapshot *Snapshot) Remove() error { func (snapshot *Snapshot) Remove() error {
if err := snapshot.validate(snapshotNeedsName | imageIsOpen); err != nil { if err := snapshot.validate(snapshotNeedsName | imageIsOpen); err != nil {
return err return err
@ -68,9 +76,10 @@ func (snapshot *Snapshot) Remove() error {
return getError(C.rbd_snap_remove(snapshot.image.image, c_snapname)) return getError(C.rbd_snap_remove(snapshot.image.image, c_snapname))
} }
// int rbd_snap_rollback(rbd_image_t image, const char *snapname); // Rollback the image to the snapshot.
// int rbd_snap_rollback_with_progress(rbd_image_t image, const char *snapname, //
// librbd_progress_fn_t cb, void *cbdata); // Implements:
// int rbd_snap_rollback(rbd_image_t image, const char *snapname);
func (snapshot *Snapshot) Rollback() error { func (snapshot *Snapshot) Rollback() error {
if err := snapshot.validate(snapshotNeedsName | imageIsOpen); err != nil { if err := snapshot.validate(snapshotNeedsName | imageIsOpen); err != nil {
return err return err
@ -82,7 +91,10 @@ func (snapshot *Snapshot) Rollback() error {
return getError(C.rbd_snap_rollback(snapshot.image.image, c_snapname)) return getError(C.rbd_snap_rollback(snapshot.image.image, c_snapname))
} }
// int rbd_snap_protect(rbd_image_t image, const char *snap_name); // Protect a snapshot from unwanted deletion.
//
// Implements:
// int rbd_snap_protect(rbd_image_t image, const char *snap_name);
func (snapshot *Snapshot) Protect() error { func (snapshot *Snapshot) Protect() error {
if err := snapshot.validate(snapshotNeedsName | imageIsOpen); err != nil { if err := snapshot.validate(snapshotNeedsName | imageIsOpen); err != nil {
return err return err
@ -94,7 +106,10 @@ func (snapshot *Snapshot) Protect() error {
return getError(C.rbd_snap_protect(snapshot.image.image, c_snapname)) return getError(C.rbd_snap_protect(snapshot.image.image, c_snapname))
} }
// int rbd_snap_unprotect(rbd_image_t image, const char *snap_name); // Unprotect stops protecting the snapshot.
//
// Implements:
// int rbd_snap_unprotect(rbd_image_t image, const char *snap_name);
func (snapshot *Snapshot) Unprotect() error { func (snapshot *Snapshot) Unprotect() error {
if err := snapshot.validate(snapshotNeedsName | imageIsOpen); err != nil { if err := snapshot.validate(snapshotNeedsName | imageIsOpen); err != nil {
return err return err
@ -106,7 +121,10 @@ func (snapshot *Snapshot) Unprotect() error {
return getError(C.rbd_snap_unprotect(snapshot.image.image, c_snapname)) return getError(C.rbd_snap_unprotect(snapshot.image.image, c_snapname))
} }
// int rbd_snap_is_protected(rbd_image_t image, const char *snap_name, // IsProtected returns true if the snapshot is currently protected.
//
// Implements:
// int rbd_snap_is_protected(rbd_image_t image, const char *snap_name,
// int *is_protected); // int *is_protected);
func (snapshot *Snapshot) IsProtected() (bool, error) { func (snapshot *Snapshot) IsProtected() (bool, error) {
if err := snapshot.validate(snapshotNeedsName | imageIsOpen); err != nil { if err := snapshot.validate(snapshotNeedsName | imageIsOpen); err != nil {
@ -127,7 +145,11 @@ func (snapshot *Snapshot) IsProtected() (bool, error) {
return c_is_protected != 0, nil return c_is_protected != 0, nil
} }
// int rbd_snap_set(rbd_image_t image, const char *snapname); // Set updates the rbd image (not the Snapshot) such that the snapshot
// is the source of readable data.
//
// Implements:
// int rbd_snap_set(rbd_image_t image, const char *snapname);
func (snapshot *Snapshot) Set() error { func (snapshot *Snapshot) Set() error {
if err := snapshot.validate(snapshotNeedsName | imageIsOpen); err != nil { if err := snapshot.validate(snapshotNeedsName | imageIsOpen); err != nil {
return err return err