RepoMirrors/go-ceph
1
0
Fork 0
mirror of https://github.com/ceph/go-ceph synced 2025-01-28 00:53:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

rados: improve clean up of temporary file used in test

Browse Source 
Clean up the temporary file using a defer and make sure that the
errors returned by the functions in the defer func are checked.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
This commit is contained in:
John Mulligan 2020-04-08 16:40:41 -04:00 committed by John Mulligan
parent c4f8f0445a
commit a1de43cd5d
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
rados/rados_test.go
View File

@ -193,7 +193,11 @@ func (suite *RadosTestSuite) TestReadConfigFile() {
// create conf file that changes log_file conf option // create conf file that changes log_file conf option
file, err := ioutil.TempFile("/tmp", "go-rados") file, err := ioutil.TempFile("/tmp", "go-rados")
assert.NoError(suite.T(), err) require.NoError(suite.T(), err)
defer func() {
assert.NoError(suite.T(), file.Close())
assert.NoError(suite.T(), os.Remove(file.Name()))
}()
next_val := prev_val + 1 next_val := prev_val + 1
conf := fmt.Sprintf("[global]\nlog_max_new = %d\n", next_val) conf := fmt.Sprintf("[global]\nlog_max_new = %d\n", next_val)
@ -213,9 +217,6 @@ func (suite *RadosTestSuite) TestReadConfigFile() {
assert.NotEqual(suite.T(), prev_str, curr_str) assert.NotEqual(suite.T(), prev_str, curr_str)
assert.Equal(suite.T(), curr_val, prev_val+1) assert.Equal(suite.T(), curr_val, prev_val+1)
file.Close()
os.Remove(file.Name())
} }
func (suite *RadosTestSuite) TestGetClusterStats() { func (suite *RadosTestSuite) TestGetClusterStats() {