RepoMirrors/go-ceph
1
0
Fork 0
mirror of https://github.com/ceph/go-ceph synced 2025-01-11 16:49:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #63 from dswarbrick/fix-snapshot-unopened-parent

Browse Source 
Check that parent image is open before attempting snapshot operations
This commit is contained in:
Noah Watkins 2018-09-14 07:55:28 -07:00 committed by GitHub
commit 92db4f867c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
rbd/rbd.go
View File

@ -817,6 +817,10 @@ func (image *Image) GetParentInfo(p_pool, p_name, p_snapname []byte) error {
// int rbd_snap_remove(rbd_image_t image, const char *snapname);
func (snapshot *Snapshot) Remove() error {
if snapshot.image.image == nil {
return RbdErrorImageNotOpen
}
var c_snapname *C.char = C.CString(snapshot.name)
defer C.free(unsafe.Pointer(c_snapname))
@ -827,6 +831,10 @@ func (snapshot *Snapshot) Remove() error {
// int rbd_snap_rollback_with_progress(rbd_image_t image, const char *snapname,
// librbd_progress_fn_t cb, void *cbdata);
func (snapshot *Snapshot) Rollback() error {
if snapshot.image.image == nil {
return RbdErrorImageNotOpen
}
var c_snapname *C.char = C.CString(snapshot.name)
defer C.free(unsafe.Pointer(c_snapname))
@ -835,6 +843,10 @@ func (snapshot *Snapshot) Rollback() error {
// int rbd_snap_protect(rbd_image_t image, const char *snap_name);
func (snapshot *Snapshot) Protect() error {
if snapshot.image.image == nil {
return RbdErrorImageNotOpen
}
var c_snapname *C.char = C.CString(snapshot.name)
defer C.free(unsafe.Pointer(c_snapname))
@ -843,6 +855,10 @@ func (snapshot *Snapshot) Protect() error {
// int rbd_snap_unprotect(rbd_image_t image, const char *snap_name);
func (snapshot *Snapshot) Unprotect() error {
if snapshot.image.image == nil {
return RbdErrorImageNotOpen
}
var c_snapname *C.char = C.CString(snapshot.name)
defer C.free(unsafe.Pointer(c_snapname))
@ -852,6 +868,10 @@ func (snapshot *Snapshot) Unprotect() error {
// int rbd_snap_is_protected(rbd_image_t image, const char *snap_name,
// int *is_protected);
func (snapshot *Snapshot) IsProtected() (bool, error) {
if snapshot.image.image == nil {
return false, RbdErrorImageNotOpen
}
var c_is_protected C.int
var c_snapname *C.char = C.CString(snapshot.name)
defer C.free(unsafe.Pointer(c_snapname))
@ -867,6 +887,10 @@ func (snapshot *Snapshot) IsProtected() (bool, error) {
// int rbd_snap_set(rbd_image_t image, const char *snapname);
func (snapshot *Snapshot) Set() error {
if snapshot.image.image == nil {
return RbdErrorImageNotOpen
}
var c_snapname *C.char = C.CString(snapshot.name)
defer C.free(unsafe.Pointer(c_snapname))