RepoMirrors
/
go-ceph
mirror of https://github.com/ceph/go-ceph
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rados: free object list results after listing 

This fixes a memory leak that becomes substantial across large pools.

Signed-off-by: Nick Janus <github@nondesignated.com>
This commit is contained in:
Nick Janus 2023-03-14 16:23:30 -04:00 committed by mergify[bot]
parent 7607fd801b
commit 5bb75604fa
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
rados/ioctx.go
View File

@ -332,7 +332,8 @@ func (ioctx *IOContext) ListObjects(listFn ObjectListFunc) error {
defer C.rados_object_list_cursor_free(ioctx.ioctx, finish) defer C.rados_object_list_cursor_free(ioctx.ioctx, finish)
for { for {
ret := C.rados_object_list(ioctx.ioctx, next, finish, pageResults, nil, filterLen, (*C.rados_object_list_item)(unsafe.Pointer(&results[0])), &next) res := (*C.rados_object_list_item)(unsafe.Pointer(&results[0]))
ret := C.rados_object_list(ioctx.ioctx, next, finish, pageResults, nil, filterLen, res, &next)
if ret < 0 { if ret < 0 {
return getError(ret) return getError(ret)
} }
@ -342,6 +343,7 @@ func (ioctx *IOContext) ListObjects(listFn ObjectListFunc) error {
item := results[i] item := results[i]
listFn(C.GoStringN(item.oid, (C.int)(item.oid_length))) listFn(C.GoStringN(item.oid, (C.int)(item.oid_length)))
} }
C.rados_object_list_free(C.size_t(ret), res)
if C.rados_object_list_is_end(ioctx.ioctx, next) == listEndSentinel { if C.rados_object_list_is_end(ioctx.ioctx, next) == listEndSentinel {
return nil return nil