From 36abb07dc509596d8615f28b37724d9b1be54535 Mon Sep 17 00:00:00 2001 From: John Mulligan Date: Wed, 11 Nov 2020 16:25:31 -0500 Subject: [PATCH] cephfs: add a test case for calling Statx on an invalid mount Adding this test case gets test coverage to 100% for path.go. Signed-off-by: John Mulligan --- cephfs/path_test.go | 34 +++++++++++++++++++++------------- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/cephfs/path_test.go b/cephfs/path_test.go index 3a8c19c..c1dfefe 100644 --- a/cephfs/path_test.go +++ b/cephfs/path_test.go @@ -359,23 +359,31 @@ func TestReadlink(t *testing.T) { } func TestStatx(t *testing.T) { - mount := fsConnect(t) - defer fsDisconnect(t, mount) + t.Run("statPath", func(t *testing.T) { + mount := fsConnect(t) + defer fsDisconnect(t, mount) - dirname := "statme" - assert.NoError(t, mount.MakeDir(dirname, 0755)) + dirname := "statme" + assert.NoError(t, mount.MakeDir(dirname, 0755)) - st, err := mount.Statx(dirname, StatxBasicStats, 0) - assert.NoError(t, err) - assert.NotNil(t, st) - assert.Equal(t, uint16(0755), st.Mode&0777) + st, err := mount.Statx(dirname, StatxBasicStats, 0) + assert.NoError(t, err) + assert.NotNil(t, st) + assert.Equal(t, uint16(0755), st.Mode&0777) - assert.NoError(t, mount.RemoveDir(dirname)) + assert.NoError(t, mount.RemoveDir(dirname)) - st, err = mount.Statx(dirname, StatxBasicStats, 0) - assert.Error(t, err) - assert.Nil(t, st) - assert.Equal(t, errNoEntry, err) + st, err = mount.Statx(dirname, StatxBasicStats, 0) + assert.Error(t, err) + assert.Nil(t, st) + assert.Equal(t, errNoEntry, err) + }) + + t.Run("invalidMount", func(t *testing.T) { + m := &MountInfo{} + _, err := m.Statx("junk", StatxBasicStats, 0) + assert.Error(t, err) + }) } func TestRename(t *testing.T) {