RepoMirrors
/
go-ceph
mirror of https://github.com/ceph/go-ceph
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
go-ceph/Makefile

77 lines
2.4 KiB
Makefile
Raw Normal View History

Add a simple makefile Primarily allowing for testing via docker; and other simple stuff like fmt Signed-off-by: Abhishek Lekshmanan <abhishek.lekshmanan@gmail.com>
2015-05-24 08:13:05 +00:00
DOCKER_CI_IMAGE = go-ceph-ci
makefile: support using other container runtimes Add new variables to the Makefile that allow the use of other container runtimes (that have a docker compatible cli) and allow setting extra opts to work on platforms that don't run apparmor. All defaults continue to be the same as before. Signed-off-by: John Mulligan <jmulligan@redhat.com>
2019-10-21 23:04:22 +00:00
CONTAINER_CMD := docker
Makefile: Fix CONTAINER_OPTS for Fedora make test-container is failing on Fedora based distribution because of bad label option "disabled". Change label option to "disable" Signed-off-by: Mudit Agarwal <muagarwa@redhat.com>
2020-04-23 10:50:12 +00:00
CONTAINER_OPTS := --security-opt $(shell grep -q selinux /sys/kernel/security/lsm && echo "label=disable" || echo "apparmor:unconfined")
makefile: use ceph based containers by default Signed-off-by: John Mulligan <jmulligan@redhat.com>
2020-03-11 18:57:27 +00:00
CONTAINER_CONFIG_DIR := testing/containers/ceph
make: add support for running test-docker on SElinux enabled systems When running 'make test-docker' on Fedora with SElinux in Enforcing mode, fetching dependencies for the project fails. It seems the volume is not accessible to the container. Enabling SElinux for the volume (by passing the :z flag) makes it work. Signed-off-by: Niels de Vos <ndevos@redhat.com>
2019-11-04 14:22:35 +00:00
VOLUME_FLAGS :=
tests: parameterize Ceph version for container build and build-tags Pass `CEPH_VERSION=minic` (or 'luminous') on the `make test-docker` command to select building a container with a different Ceph version and running the tests in it. This passes the given CEPH_VERSION on to the `docker build` command as a --build-arg, which gets used for selecting the Ceph repository during container build. It also sets the environment variable CEPH_VERSION, which in turn is consumed by `entrypoint.sh` to set the `go build -tags ${CEPH_VERSION}` option that includes/excludes certain *.go files. See-also: https://golang.org/pkg/go/build/#hdr-Build_Constraints Signed-off-by: Niels de Vos <ndevos@redhat.com>
2019-12-17 15:50:58 +00:00
CEPH_VERSION := nautilus
makefile: support getting results locally from container test Signed-off-by: John Mulligan <jmulligan@redhat.com>
2020-04-17 15:29:30 +00:00
RESULTS_DIR :=
makefile: include formatting as part of "make check" Previously, "make check" only ran revive and its static checks. The entrypoint.sh script ran a formatting check *after* setting up ceph. Now, "make check" runs both revive and gofmt. New make rules check-revive and check-format run the individual tools respectively. This is done to quicken the feedback in both the CI and locally for formatting mistakes. Users can now easily run `make check test-container` and avoid a long wait to set up ceph just to find out there was a silly formatting error present. Signed-off-by: John Mulligan <jmulligan@redhat.com>
2020-05-13 21:01:32 +00:00
CHECK_GOFMT_FLAGS := -e -s -l
make: add support for running test-docker on SElinux enabled systems When running 'make test-docker' on Fedora with SElinux in Enforcing mode, fetching dependencies for the project fails. It seems the volume is not accessible to the container. Enabling SElinux for the volume (by passing the :z flag) makes it work. Signed-off-by: Niels de Vos <ndevos@redhat.com>
2019-11-04 14:22:35 +00:00
SELINUX := $(shell getenforce 2>/dev/null)
ifeq ($(SELINUX),Enforcing)
VOLUME_FLAGS = :z
endif
makefile: support using other container runtimes Add new variables to the Makefile that allow the use of other container runtimes (that have a docker compatible cli) and allow setting extra opts to work on platforms that don't run apparmor. All defaults continue to be the same as before. Signed-off-by: John Mulligan <jmulligan@redhat.com>
2019-10-21 23:04:22 +00:00
makefile: support getting results locally from container test Signed-off-by: John Mulligan <jmulligan@redhat.com>
2020-04-17 15:29:30 +00:00
ifdef RESULTS_DIR
RESULTS_VOLUME := -v $(RESULTS_DIR):/results$(VOLUME_FLAGS)
endif
Add a simple makefile Primarily allowing for testing via docker; and other simple stuff like fmt Signed-off-by: Abhishek Lekshmanan <abhishek.lekshmanan@gmail.com>
2015-05-24 08:13:05 +00:00
build:
tests: parameterize Ceph version for container build and build-tags Pass `CEPH_VERSION=minic` (or 'luminous') on the `make test-docker` command to select building a container with a different Ceph version and running the tests in it. This passes the given CEPH_VERSION on to the `docker build` command as a --build-arg, which gets used for selecting the Ceph repository during container build. It also sets the environment variable CEPH_VERSION, which in turn is consumed by `entrypoint.sh` to set the `go build -tags ${CEPH_VERSION}` option that includes/excludes certain *.go files. See-also: https://golang.org/pkg/go/build/#hdr-Build_Constraints Signed-off-by: Niels de Vos <ndevos@redhat.com>
2019-12-17 15:50:58 +00:00
go build -v -tags $(CEPH_VERSION) $(shell go list ./... | grep -v /contrib)
Add a simple makefile Primarily allowing for testing via docker; and other simple stuff like fmt Signed-off-by: Abhishek Lekshmanan <abhishek.lekshmanan@gmail.com>
2015-05-24 08:13:05 +00:00
fmt:
go fmt ./...
test:
go test -v ./...
makefile: add rules for explicitly creating the ci container image Signed-off-by: John Mulligan <jmulligan@redhat.com>
2020-03-11 17:50:23 +00:00
.PHONY: test-docker test-container
test-docker: test-container
makefile: support getting results locally from container test Signed-off-by: John Mulligan <jmulligan@redhat.com>
2020-04-17 15:29:30 +00:00
test-container: check-ceph-version .build-docker $(RESULTS_DIR)
$(CONTAINER_CMD) run --device /dev/fuse --cap-add SYS_ADMIN $(CONTAINER_OPTS) --rm -v $(CURDIR):/go/src/github.com/ceph/go-ceph$(VOLUME_FLAGS) $(RESULTS_VOLUME) $(DOCKER_CI_IMAGE)
ifdef RESULTS_DIR
$(RESULTS_DIR):
mkdir -p $(RESULTS_DIR)
endif
Add a simple makefile Primarily allowing for testing via docker; and other simple stuff like fmt Signed-off-by: Abhishek Lekshmanan <abhishek.lekshmanan@gmail.com>
2015-05-24 08:13:05 +00:00
makefile: add rules for explicitly creating the ci container image Signed-off-by: John Mulligan <jmulligan@redhat.com>
2020-03-11 17:50:23 +00:00
.PHONY: ci-image
ci-image: .build-docker
makefile: support selecting alternate container builds Signed-off-by: John Mulligan <jmulligan@redhat.com>
2020-03-11 18:52:53 +00:00
.build-docker: $(CONTAINER_CONFIG_DIR)/Dockerfile entrypoint.sh
$(CONTAINER_CMD) build --build-arg CEPH_VERSION=$(CEPH_VERSION) -t $(DOCKER_CI_IMAGE) -f $(CONTAINER_CONFIG_DIR)/Dockerfile .
makefile: support using other container runtimes Add new variables to the Makefile that allow the use of other container runtimes (that have a docker compatible cli) and allow setting extra opts to work on platforms that don't run apparmor. All defaults continue to be the same as before. Signed-off-by: John Mulligan <jmulligan@redhat.com>
2019-10-21 23:04:22 +00:00
@$(CONTAINER_CMD) inspect -f '{{.Id}}' $(DOCKER_CI_IMAGE) > .build-docker
tests: parameterize Ceph version for container build and build-tags Pass `CEPH_VERSION=minic` (or 'luminous') on the `make test-docker` command to select building a container with a different Ceph version and running the tests in it. This passes the given CEPH_VERSION on to the `docker build` command as a --build-arg, which gets used for selecting the Ceph repository during container build. It also sets the environment variable CEPH_VERSION, which in turn is consumed by `entrypoint.sh` to set the `go build -tags ${CEPH_VERSION}` option that includes/excludes certain *.go files. See-also: https://golang.org/pkg/go/build/#hdr-Build_Constraints Signed-off-by: Niels de Vos <ndevos@redhat.com>
2019-12-17 15:50:58 +00:00
echo $(CEPH_VERSION) >> .build-docker
# check-ceph-version checks for the last used Ceph version in the container
# image and forces a rebuild of the image in case the Ceph version changed
.PHONY: check-ceph-version
check-ceph-version:
@grep -wq '$(CEPH_VERSION)' .build-docker 2>/dev/null || $(RM) .build-docker
Enable golint in travis and Makefile
2018-12-10 22:17:39 +00:00
makefile: include formatting as part of "make check" Previously, "make check" only ran revive and its static checks. The entrypoint.sh script ran a formatting check *after* setting up ceph. Now, "make check" runs both revive and gofmt. New make rules check-revive and check-format run the individual tools respectively. This is done to quicken the feedback in both the CI and locally for formatting mistakes. Users can now easily run `make check test-container` and avoid a long wait to set up ceph just to find out there was a silly formatting error present. Signed-off-by: John Mulligan <jmulligan@redhat.com>
2020-05-13 21:01:32 +00:00
check: check-revive check-format
check-format:
! gofmt $(CHECK_GOFMT_FLAGS) . | sed 's,^,formatting error: ,' | grep 'go$$'
check-revive:
makefile: use revive for style checking Switch use of style checker from golint to revive for both the makefile and travis configuration. Signed-off-by: John Mulligan <jmulligan@redhat.com>
2019-12-12 02:04:19 +00:00
# Configure project's revive checks using .revive.toml
# See: https://github.com/mgechev/revive
makefile: remove shell loop that was ignoring errors revive would only fail if rbd had errors due to the loop being in shell. Now we expand the modules list as arguments to revive which then invokes revive only once and properly handles errors. Signed-off-by: John Mulligan <jmulligan@redhat.com>
2020-03-28 17:20:13 +00:00
revive -config .revive.toml $$(go list ./... | grep -v /vendor/)
makefile: add targets for test binaries The go test command's -c switch builds the test binary but does not execute it. It is convenient to do quick compile checks of the libraries and test code at once without having to bring up the ceph instance in the test container. This change allows one to run 'make test-bins' or 'make rbd.test' to compile but not run the test & library code. Signed-off-by: John Mulligan <jmulligan@redhat.com>
2020-02-04 19:46:17 +00:00
# Do a quick compile only check of the tests and impliclity the
# library code as well.
entrypoint: enable building and testing of internal/cutil package Signed-off-by: John Mulligan <jmulligan@redhat.com>
2020-04-13 15:22:39 +00:00
test-binaries: \
cephfs.test \
internal/callbacks.test \
internal/cutil.test \
internal/errutil.test \
internal/retry.test \
rados.test \
rbd.test
makefile: add targets for test binaries The go test command's -c switch builds the test binary but does not execute it. It is convenient to do quick compile checks of the libraries and test code at once without having to bring up the ceph instance in the test container. This change allows one to run 'make test-bins' or 'make rbd.test' to compile but not run the test & library code. Signed-off-by: John Mulligan <jmulligan@redhat.com>
2020-02-04 19:46:17 +00:00
test-bins: test-binaries
%.test: % force_go_build
go test -c ./$<
# force_go_build is phony and builds nothing, can be used for forcing
# go toolchain commands to always run
.PHONY: build fmt test test-docker check test-binaries test-bins force_go_build