mirror of
https://git.ffmpeg.org/ffmpeg.git
synced 2024-12-26 01:02:33 +00:00
e8a1e1899d
Failure is possible due to strdup() Fixes: CID1516764 Dereference null return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
168 lines
6.0 KiB
C
168 lines
6.0 KiB
C
/*
|
|
* copyright (c) 2009 Michael Niedermayer
|
|
*
|
|
* This file is part of FFmpeg.
|
|
*
|
|
* FFmpeg is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2.1 of the License, or (at your option) any later version.
|
|
*
|
|
* FFmpeg is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with FFmpeg; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
|
|
*/
|
|
|
|
#include "libavutil/mem.h"
|
|
|
|
#include "libavutil/dict.c"
|
|
|
|
static const AVDictionaryEntry *dict_iterate(const AVDictionary *m,
|
|
const AVDictionaryEntry *prev)
|
|
{
|
|
const AVDictionaryEntry *dict_get = av_dict_get(m, "", prev, AV_DICT_IGNORE_SUFFIX);
|
|
const AVDictionaryEntry *dict_iterate = av_dict_iterate(m, prev);
|
|
|
|
if (dict_get != dict_iterate) {
|
|
#define GET(entry, mem) ((entry) ? (entry)->mem : "N/A")
|
|
printf("Iterating with av_dict_iterate() yields a different result "
|
|
"than iterating with av_dict_get() and AV_DICT_IGNORE_SUFFIX "
|
|
"(prev: %p, key %s; av_dict_iterate() %p, key %s, value %s; "
|
|
"av_dict_get() %p, key %s, value %s)\n",
|
|
prev, GET(prev, key),
|
|
dict_iterate, GET(dict_iterate, key), GET(dict_iterate, value),
|
|
dict_get, GET(dict_get, key), GET(dict_get, value));
|
|
#undef GET
|
|
}
|
|
return dict_iterate;
|
|
}
|
|
|
|
static void print_dict(const AVDictionary *m)
|
|
{
|
|
const AVDictionaryEntry *t = NULL;
|
|
while ((t = dict_iterate(m, t)))
|
|
printf("%s %s ", t->key, t->value);
|
|
printf("\n");
|
|
}
|
|
|
|
static void test_separators(const AVDictionary *m, const char pair, const char val)
|
|
{
|
|
AVDictionary *dict = NULL;
|
|
char pairs[] = {pair , '\0'};
|
|
char vals[] = {val, '\0'};
|
|
|
|
char *buffer = NULL;
|
|
int ret;
|
|
|
|
av_dict_copy(&dict, m, 0);
|
|
print_dict(dict);
|
|
av_dict_get_string(dict, &buffer, val, pair);
|
|
printf("%s\n", buffer);
|
|
av_dict_free(&dict);
|
|
ret = av_dict_parse_string(&dict, buffer, vals, pairs, 0);
|
|
printf("ret %d\n", ret);
|
|
av_freep(&buffer);
|
|
print_dict(dict);
|
|
av_dict_free(&dict);
|
|
}
|
|
|
|
int main(void)
|
|
{
|
|
AVDictionary *dict = NULL;
|
|
const AVDictionaryEntry *e;
|
|
char *buffer = NULL;
|
|
|
|
printf("Testing av_dict_get_string() and av_dict_parse_string()\n");
|
|
av_dict_get_string(dict, &buffer, '=', ',');
|
|
printf("%s\n", buffer);
|
|
av_freep(&buffer);
|
|
av_dict_set(&dict, "aaa", "aaa", 0);
|
|
av_dict_set(&dict, "b,b", "bbb", 0);
|
|
av_dict_set(&dict, "c=c", "ccc", 0);
|
|
av_dict_set(&dict, "ddd", "d,d", 0);
|
|
av_dict_set(&dict, "eee", "e=e", 0);
|
|
av_dict_set(&dict, "f,f", "f=f", 0);
|
|
av_dict_set(&dict, "g=g", "g,g", 0);
|
|
test_separators(dict, ',', '=');
|
|
av_dict_free(&dict);
|
|
av_dict_set(&dict, "aaa", "aaa", 0);
|
|
av_dict_set(&dict, "bbb", "bbb", 0);
|
|
av_dict_set(&dict, "ccc", "ccc", 0);
|
|
av_dict_set(&dict, "\\,=\'\"", "\\,=\'\"", 0);
|
|
test_separators(dict, '"', '=');
|
|
test_separators(dict, '\'', '=');
|
|
test_separators(dict, ',', '"');
|
|
test_separators(dict, ',', '\'');
|
|
test_separators(dict, '\'', '"');
|
|
test_separators(dict, '"', '\'');
|
|
av_dict_free(&dict);
|
|
|
|
printf("\nTesting av_dict_set()\n");
|
|
av_dict_set(&dict, "a", "a", 0);
|
|
av_dict_set(&dict, "b", av_strdup("b"), AV_DICT_DONT_STRDUP_VAL);
|
|
av_dict_set(&dict, av_strdup("c"), "c", AV_DICT_DONT_STRDUP_KEY);
|
|
av_dict_set(&dict, av_strdup("d"), av_strdup("d"), AV_DICT_DONT_STRDUP_KEY | AV_DICT_DONT_STRDUP_VAL);
|
|
av_dict_set(&dict, "e", "e", AV_DICT_DONT_OVERWRITE);
|
|
av_dict_set(&dict, "e", "f", AV_DICT_DONT_OVERWRITE);
|
|
av_dict_set(&dict, "f", "f", 0);
|
|
av_dict_set(&dict, "f", NULL, 0);
|
|
av_dict_set(&dict, "ff", "f", 0);
|
|
av_dict_set(&dict, "ff", "f", AV_DICT_APPEND);
|
|
if (av_dict_get(dict, NULL, NULL, 0))
|
|
printf("av_dict_get() does not correctly handle NULL key.\n");
|
|
e = NULL;
|
|
while ((e = dict_iterate(dict, e)))
|
|
printf("%s %s\n", e->key, e->value);
|
|
av_dict_free(&dict);
|
|
|
|
if (av_dict_set(&dict, NULL, "a", 0) >= 0 ||
|
|
av_dict_set(&dict, NULL, "b", 0) >= 0 ||
|
|
av_dict_set(&dict, NULL, NULL, AV_DICT_DONT_STRDUP_KEY) >= 0 ||
|
|
av_dict_set(&dict, NULL, av_strdup("b"), AV_DICT_DONT_STRDUP_VAL) >= 0 ||
|
|
av_dict_count(dict))
|
|
printf("av_dict_set does not correctly handle NULL key\n");
|
|
|
|
e = NULL;
|
|
while ((e = dict_iterate(dict, e)))
|
|
printf("'%s' '%s'\n", e->key, e->value);
|
|
av_dict_free(&dict);
|
|
|
|
|
|
//valgrind sensible test
|
|
printf("\nTesting av_dict_set_int()\n");
|
|
av_dict_set_int(&dict, "1", 1, AV_DICT_DONT_STRDUP_VAL);
|
|
av_dict_set_int(&dict, av_strdup("2"), 2, AV_DICT_DONT_STRDUP_KEY);
|
|
av_dict_set_int(&dict, av_strdup("3"), 3, AV_DICT_DONT_STRDUP_KEY | AV_DICT_DONT_STRDUP_VAL);
|
|
av_dict_set_int(&dict, "4", 4, 0);
|
|
av_dict_set_int(&dict, "5", 5, AV_DICT_DONT_OVERWRITE);
|
|
av_dict_set_int(&dict, "5", 6, AV_DICT_DONT_OVERWRITE);
|
|
av_dict_set_int(&dict, "12", 1, 0);
|
|
av_dict_set_int(&dict, "12", 2, AV_DICT_APPEND);
|
|
e = NULL;
|
|
while ((e = dict_iterate(dict, e)))
|
|
printf("%s %s\n", e->key, e->value);
|
|
av_dict_free(&dict);
|
|
|
|
//valgrind sensible test
|
|
printf("\nTesting av_dict_set() with existing AVDictionaryEntry.key as key\n");
|
|
if (av_dict_set(&dict, "key", "old", 0) < 0)
|
|
return 1;
|
|
e = av_dict_get(dict, "key", NULL, 0);
|
|
if (av_dict_set(&dict, e->key, "new val OK", 0) < 0)
|
|
return 1;
|
|
e = av_dict_get(dict, "key", NULL, 0);
|
|
printf("%s\n", e->value);
|
|
if (av_dict_set(&dict, e->key, e->value, 0) < 0)
|
|
return 1;
|
|
e = av_dict_get(dict, "key", NULL, 0);
|
|
printf("%s\n", e->value);
|
|
av_dict_free(&dict);
|
|
|
|
return 0;
|
|
}
|