mirror of https://git.ffmpeg.org/ffmpeg.git
ffbd1d2b00
This work is sponsored by, and copyright, Google.
The filter coefficients are signed values, where the product of the
multiplication with one individual filter coefficient doesn't
overflow a 16 bit signed value (the largest filter coefficient is
127). But when the products are accumulated, the resulting sum can
overflow the 16 bit signed range. Instead of accumulating in 32 bit,
we accumulate the largest product (either index 3 or 4) last with a
saturated addition.
(The VP8 MC asm does something similar, but slightly simpler, by
accumulating each half of the filter separately. In the VP9 MC
filters, each half of the filter can also overflow though, so the
largest component has to be handled individually.)
Examples of relative speedup compared to the C version, from checkasm:
Cortex A7 A8 A9 A53
vp9_avg4_neon: 1.71 1.15 1.42 1.49
vp9_avg8_neon: 2.51 3.63 3.14 2.58
vp9_avg16_neon: 2.95 6.76 3.01 2.84
vp9_avg32_neon: 3.29 6.64 2.85 3.00
vp9_avg64_neon: 3.47 6.67 3.14 2.80
vp9_avg_8tap_smooth_4h_neon: 3.22 4.73 2.76 4.67
vp9_avg_8tap_smooth_4hv_neon: 3.67 4.76 3.28 4.71
vp9_avg_8tap_smooth_4v_neon: 5.52 7.60 4.60 6.31
vp9_avg_8tap_smooth_8h_neon: 6.22 9.04 5.12 9.32
vp9_avg_8tap_smooth_8hv_neon: 6.38 8.21 5.72 8.17
vp9_avg_8tap_smooth_8v_neon: 9.22 12.66 8.15 11.10
vp9_avg_8tap_smooth_64h_neon: 7.02 10.23 5.54 11.58
vp9_avg_8tap_smooth_64hv_neon: 6.76 9.46 5.93 9.40
vp9_avg_8tap_smooth_64v_neon: 10.76 14.13 9.46 13.37
vp9_put4_neon: 1.11 1.47 1.00 1.21
vp9_put8_neon: 1.23 2.17 1.94 1.48
vp9_put16_neon: 1.63 4.02 1.73 1.97
vp9_put32_neon: 1.56 4.92 2.00 1.96
vp9_put64_neon: 2.10 5.28 2.03 2.35
vp9_put_8tap_smooth_4h_neon: 3.11 4.35 2.63 4.35
vp9_put_8tap_smooth_4hv_neon: 3.67 4.69 3.25 4.71
vp9_put_8tap_smooth_4v_neon: 5.45 7.27 4.49 6.52
vp9_put_8tap_smooth_8h_neon: 5.97 8.18 4.81 8.56
vp9_put_8tap_smooth_8hv_neon: 6.39 7.90 5.64 8.15
vp9_put_8tap_smooth_8v_neon: 9.03 11.84 8.07 11.51
vp9_put_8tap_smooth_64h_neon: 6.78 9.48 4.88 10.89
vp9_put_8tap_smooth_64hv_neon: 6.99 8.87 5.94 9.56
vp9_put_8tap_smooth_64v_neon: 10.69 13.30 9.43 14.34
For the larger 8tap filters, the speedup vs C code is around 5-14x.
This is significantly faster than libvpx's implementation of the same
functions, at least when comparing the put_8tap_smooth_64 functions
(compared to vpx_convolve8_horiz_neon and vpx_convolve8_vert_neon from
libvpx).
Absolute runtimes from checkasm:
Cortex A7 A8 A9 A53
vp9_put_8tap_smooth_64h_neon: 20150.3 14489.4 19733.6 10863.7
libvpx vpx_convolve8_horiz_neon: 52623.3 19736.4 21907.7 25027.7
vp9_put_8tap_smooth_64v_neon: 14455.0 12303.9 13746.4 9628.9
libvpx vpx_convolve8_vert_neon: 42090.0 17706.2 17659.9 16941.2
Thus, on the A9, the horizontal filter is only marginally faster than
libvpx, while our version is significantly faster on the other cores,
and the vertical filter is significantly faster on all cores. The
difference is especially large on the A7.
The libvpx implementation does the accumulation in 32 bit, which
probably explains most of the differences.
Signed-off-by: Martin Storsjö <martin@martin.st>
|
||
|---|---|---|
| .. | ||
| Makefile | ||
| aac.h | ||
| aacpsdsp_init_arm.c | ||
| aacpsdsp_neon.S | ||
| ac3dsp_arm.S | ||
| ac3dsp_armv6.S | ||
| ac3dsp_init_arm.c | ||
| ac3dsp_neon.S | ||
| apedsp_init_arm.c | ||
| apedsp_neon.S | ||
| asm-offsets.h | ||
| audiodsp_arm.h | ||
| audiodsp_init_arm.c | ||
| audiodsp_init_neon.c | ||
| audiodsp_neon.S | ||
| blockdsp_arm.h | ||
| blockdsp_init_arm.c | ||
| blockdsp_init_neon.c | ||
| blockdsp_neon.S | ||
| cabac.h | ||
| dca.h | ||
| dcadsp_init_arm.c | ||
| dcadsp_neon.S | ||
| dcadsp_vfp.S | ||
| fft_fixed_init_arm.c | ||
| fft_fixed_neon.S | ||
| fft_init_arm.c | ||
| fft_neon.S | ||
| fft_vfp.S | ||
| flacdsp_arm.S | ||
| flacdsp_init_arm.c | ||
| fmtconvert_init_arm.c | ||
| fmtconvert_neon.S | ||
| fmtconvert_vfp.S | ||
| g722dsp_init_arm.c | ||
| g722dsp_neon.S | ||
| h264chroma_init_arm.c | ||
| h264cmc_neon.S | ||
| h264dsp_init_arm.c | ||
| h264dsp_neon.S | ||
| h264idct_neon.S | ||
| h264pred_init_arm.c | ||
| h264pred_neon.S | ||
| h264qpel_init_arm.c | ||
| h264qpel_neon.S | ||
| hpeldsp_arm.S | ||
| hpeldsp_arm.h | ||
| hpeldsp_armv6.S | ||
| hpeldsp_init_arm.c | ||
| hpeldsp_init_armv6.c | ||
| hpeldsp_init_neon.c | ||
| hpeldsp_neon.S | ||
| idct.h | ||
| idctdsp_arm.S | ||
| idctdsp_arm.h | ||
| idctdsp_armv6.S | ||
| idctdsp_init_arm.c | ||
| idctdsp_init_armv5te.c | ||
| idctdsp_init_armv6.c | ||
| idctdsp_init_neon.c | ||
| idctdsp_neon.S | ||
| int_neon.S | ||
| jrevdct_arm.S | ||
| mathops.h | ||
| mdct_fixed_init_arm.c | ||
| mdct_fixed_neon.S | ||
| mdct_init_arm.c | ||
| mdct_neon.S | ||
| mdct_vfp.S | ||
| me_cmp_armv6.S | ||
| me_cmp_init_arm.c | ||
| mlpdsp_armv5te.S | ||
| mlpdsp_armv6.S | ||
| mlpdsp_init_arm.c | ||
| mpegaudiodsp_fixed_armv6.S | ||
| mpegaudiodsp_init_arm.c | ||
| mpegvideo_arm.c | ||
| mpegvideo_arm.h | ||
| mpegvideo_armv5te.c | ||
| mpegvideo_armv5te_s.S | ||
| mpegvideo_neon.S | ||
| mpegvideoencdsp_armv6.S | ||
| mpegvideoencdsp_init_arm.c | ||
| neon.S | ||
| neontest.c | ||
| pixblockdsp_armv6.S | ||
| pixblockdsp_init_arm.c | ||
| rdft_init_arm.c | ||
| rdft_neon.S | ||
| rv34dsp_init_arm.c | ||
| rv34dsp_neon.S | ||
| rv40dsp_init_arm.c | ||
| rv40dsp_neon.S | ||
| sbrdsp_init_arm.c | ||
| sbrdsp_neon.S | ||
| simple_idct_arm.S | ||
| simple_idct_armv5te.S | ||
| simple_idct_armv6.S | ||
| simple_idct_neon.S | ||
| startcode.h | ||
| startcode_armv6.S | ||
| synth_filter_neon.S | ||
| synth_filter_vfp.S | ||
| vc1dsp.h | ||
| vc1dsp_init_arm.c | ||
| vc1dsp_init_neon.c | ||
| vc1dsp_neon.S | ||
| videodsp_arm.h | ||
| videodsp_armv5te.S | ||
| videodsp_init_arm.c | ||
| videodsp_init_armv5te.c | ||
| vorbisdsp_init_arm.c | ||
| vorbisdsp_neon.S | ||
| vp3dsp_init_arm.c | ||
| vp3dsp_neon.S | ||
| vp6dsp_init_arm.c | ||
| vp6dsp_neon.S | ||
| vp8.h | ||
| vp8_armv6.S | ||
| vp8dsp.h | ||
| vp8dsp_armv6.S | ||
| vp8dsp_init_arm.c | ||
| vp8dsp_init_armv6.c | ||
| vp8dsp_init_neon.c | ||
| vp8dsp_neon.S | ||
| vp9dsp_init_arm.c | ||
| vp9mc_neon.S | ||
| vp56_arith.h | ||