Commit Graph

66 Commits

Author SHA1 Message Date
Andreas Rheinhardt 8be701d9f7 avfilter/avfilter: Add numbers of (in|out)pads directly to AVFilter
Up until now, an AVFilter's lists of input and output AVFilterPads
were terminated by a sentinel and the only way to get the length
of these lists was by using avfilter_pad_count(). This has two
drawbacks: first, sizeof(AVFilterPad) is not negligible
(i.e. 64B on 64bit systems); second, getting the size involves
a function call instead of just reading the data.

This commit therefore changes this. The sentinels are removed and new
private fields nb_inputs and nb_outputs are added to AVFilter that
contain the number of elements of the respective AVFilterPad array.

Given that AVFilter.(in|out)puts are the only arrays of zero-terminated
AVFilterPads an API user has access to (AVFilterContext.(in|out)put_pads
are not zero-terminated and they already have a size field) the argument
to avfilter_pad_count() is always one of these lists, so it just has to
find the filter the list belongs to and read said number. This is slower
than before, but a replacement function that just reads the internal numbers
that users are expected to switch to will be added soon; and furthermore,
avfilter_pad_count() is probably never called in hot loops anyway.

This saves about 49KiB from the binary; notice that these sentinels are
not in .bss despite being zeroed: they are in .data.rel.ro due to the
non-sentinels.

Reviewed-by: Nicolas George <george@nsup.org>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2021-08-20 12:53:58 +02:00
Paul B Mahol ca788d184c avfilter/vf_waveform: add option to control strechness of waveform 2021-08-16 01:19:19 +02:00
Andreas Rheinhardt 1b20853fb3 avfilter/internal: Factor out executing a filter's execute_func
The current way of doing it involves writing the ctx parameter twice.

Reviewed-by: Nicolas George <george@nsup.org>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2021-08-15 21:33:25 +02:00
Andreas Rheinhardt 2934a4b9a5 Remove unnecessary avassert.h inclusions
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
2021-07-22 15:02:30 +02:00
Andreas Rheinhardt a04ad248a0 avfilter: Constify all AVFilters
This is possible now that the next-API is gone.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Signed-off-by: James Almer <jamrial@gmail.com>
2021-04-27 11:48:05 -03:00
Peter Ross 5d8e86d15a avfilter/vf_waveform: flat_pix_fmts never used
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@gmail.com>
2021-01-24 09:35:36 +11:00
Nicolas George 2f76476549 lavfi: regroup formats lists in a single structure.
It will allow to refernce it as a whole without clunky macros.

Most of the changes have been automatically made with sed:

sed -i '
  s/-> *in_formats/->incfg.formats/g;
  s/-> *out_formats/->outcfg.formats/g;
  s/-> *in_channel_layouts/->incfg.channel_layouts/g;
  s/-> *out_channel_layouts/->outcfg.channel_layouts/g;
  s/-> *in_samplerates/->incfg.samplerates/g;
  s/-> *out_samplerates/->outcfg.samplerates/g;
  ' src/libavfilter/*(.)
2020-09-08 14:02:40 +02:00
Paul B Mahol 26eba8ca61 avfilter/vf_waveform: add support for 12bit yuva formats 2019-12-29 15:33:55 +01:00
Paul B Mahol 6399eed48a avfilter/vf_waveform: implement tint options 2019-12-28 21:51:40 +01:00
Paul B Mahol 4f4334bcbc avfilter/vf_waveform: fix typos which caused crash 2019-10-13 11:51:11 +02:00
Paul B Mahol e923e6205e avfilter/vf_waveform: add yflat filter 2019-10-12 18:46:13 +02:00
Paul B Mahol 33fd82ae9e avfilter/vf_waveform: allow different cb for new modes 2019-10-12 17:57:23 +02:00
Paul B Mahol 42974eb13a avfilter/vf_waveform: add invert graticule 2019-10-12 17:44:52 +02:00
Paul B Mahol ecc1675368 avfilter/vf_waveform: add graticule enum 2019-10-12 16:02:34 +02:00
Paul B Mahol 7ad69a73f3 avfilter/vf_waveform: better guard against picking wrong pixel format
Fixes #8252
2019-10-11 12:07:54 +02:00
Paul B Mahol 22d6d91649 avfilter/vf_waveform: abort early if there are no components to show 2018-10-24 18:33:52 +02:00
Paul B Mahol d94d252731 avfilter/vf_waveform: add gratcicule to rgb input 2018-10-24 18:33:52 +02:00
Paul B Mahol e9dd5b4f5e avfilter/vf_waveform: add slice threading
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2018-05-18 13:15:09 +02:00
Paul B Mahol 36cf3eb76a avfilter/vf_waveform: add orange graticule
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2018-03-21 12:21:42 +01:00
Paul B Mahol caef95737e avfilter/vf_waveform: add xflat mode
Also use macros for xflat and aflat mode.

Signed-off-by: Paul B Mahol <onemda@gmail.com>
2018-03-21 12:21:42 +01:00
Paul B Mahol 299a622297 avfilter/vf_waveform: add default case when picking input formats
Should silence compiler warnings.

Signed-off-by: Paul B Mahol <onemda@gmail.com>
2017-12-08 12:31:01 +01:00
Paul B Mahol 86222a7ea0 avfilter/vf_waveform: add support for 9 bit depth lowpass 2017-08-07 13:09:57 +02:00
Paul B Mahol 8a14374ab3 avfilter/vf_waveform: allow alpha output for >8 depth planar rgb inputs
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2017-06-25 13:14:22 +02:00
Muhammad Faiz 6af050d7d0 avfilter: do not use AVFrame accessor
Reviewed-by: wm4 <nfxjfg@googlemail.com>
Signed-off-by: Muhammad Faiz <mfcc64@gmail.com>
2017-04-23 14:40:30 +07:00
Paul B Mahol 57ef0f0f17 avfilter/vf_waveform: add gray10 and gray12 support
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-11-29 11:34:48 +01:00
Paul B Mahol 4fb6f9de0c avfilter/vf_waveform: make possible to change background opacity
Only useful if output pixel format have alpha.

Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-09-07 22:38:14 +02:00
Paul B Mahol 5b174dd3f1 avfilter/vf_waveform: fix order of graticule scale items
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-05-05 10:38:37 +02:00
Paul B Mahol 4a80a6ad21 avfilter/vf_waveform: optimize lowpass filter even more
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-29 22:02:48 +02:00
Paul B Mahol c2bbcf1607 avfilter/vf_waveform: optimize 16bit lowpass filter
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-28 12:28:03 +02:00
Paul B Mahol 48be92e5b6 avfilter/vf_waveform: optimize lowpass 8bit filter
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-27 23:29:38 +02:00
Paul B Mahol 0b9957c301 avfilter/vf_waveform: move mirror variable into function argument
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-27 22:50:04 +02:00
Paul B Mahol 50f4b64c54 avfilter/vf_waveform: set color range for output frames
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-20 10:00:53 +01:00
Paul B Mahol 959c7dad88 avfilter/vf_waveform: add graticule to aflat filter
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-19 21:47:15 +01:00
Paul B Mahol c91b20c464 avfilter/vf_waveform: add subsampling input support for remaining filters
Remove achroma filter, as same output can be done with lowpass filter
and multiple components with overlay display.

Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-19 21:18:35 +01:00
Paul B Mahol 93c6c52ad7 avfilter/vf_waveform: add subsampled input support for (a)color filter
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-18 11:08:32 +01:00
Paul B Mahol a68d4bf235 avfilter/vf_waveform: add forgotten color and acolor filter to switch case
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-15 09:16:18 +01:00
Paul B Mahol af5559ab67 avfilter/vf_waveform: add graticule for chroma and flat filter
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-14 23:12:43 +01:00
Paul B Mahol 29d106e751 avfilter/vf_waveform: remove mirroring from chroma filter
It is not really useful.

Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-14 13:25:10 +01:00
Paul B Mahol 9f6e63f6f2 avfilter/vf_waveform: add >8 bit support for other filters
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-14 13:25:10 +01:00
Paul B Mahol 912fec3e54 avfilter/vf_waveform: add acolor filter
Useful in combination with color filter.

Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-13 11:24:39 +01:00
Paul B Mahol 817d0c6da2 avfilter/vf_waveform: add parade display mode
Rename old parade display mode to stacked.

Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-11 23:08:38 +01:00
Paul B Mahol 867637caea avfilter/vf_waveform: fix and extend millivolts grat lines
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-11 10:24:51 +01:00
Paul B Mahol 119c108b31 avfilter/vf_waveform: fix ire8 for 25%
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-11 09:51:12 +01:00
Paul B Mahol 1a5895757d avfilter/vf_waveform: fix indentation
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-11 00:15:53 +01:00
Paul B Mahol 681f833610 avfilter/vf_waveform add support for other scalers for graticule
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-11 00:09:57 +01:00
Paul B Mahol 953b8c5a43 avfilter/vf_waveform: use intensity for other components too
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-09 11:51:20 +01:00
Paul B Mahol b3e0371818 avfilter/vf_waveform: make it possible to draw dots instead of lines
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-08 23:14:57 +01:00
Paul B Mahol 209cff2d9c avfilter/vf_waveform: make sure that x/y for text position is positive
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-08 22:04:57 +01:00
Paul B Mahol f659b70eb0 avfilter/vf_waveform: draw graticule for color filter too
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-07 13:27:41 +01:00
Paul B Mahol 23d8b79a18 avfilter/vf_waveform: add text to graticule
Signed-off-by: Paul B Mahol <onemda@gmail.com>
2016-03-06 16:48:05 +01:00