From e5dd4ae7284bb290d8dc8e9cd3f2e035d1d77cd0 Mon Sep 17 00:00:00 2001 From: Nicolas George Date: Wed, 29 Feb 2012 13:46:13 +0100 Subject: [PATCH] assdec: avoid a possible NULL dereference. --- libavcodec/assdec.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/assdec.c b/libavcodec/assdec.c index c5f9cab6e0..47ea3308f4 100644 --- a/libavcodec/assdec.c +++ b/libavcodec/assdec.c @@ -41,8 +41,11 @@ static int ass_decode_frame(AVCodecContext *avctx, void *data, int *got_sub_ptr, int len, size = avpkt->size; while (size > 0) { + int duration; ASSDialog *dialog = ff_ass_split_dialog(avctx->priv_data, ptr, 0, NULL); - int duration = dialog->end - dialog->start; + if (!dialog) + return AVERROR_INVALIDDATA; + duration = dialog->end - dialog->start; len = ff_ass_add_rect(data, ptr, 0, duration, 1); if (len < 0) return len;