From e3b5316bede3cf735f66a0a1b83ca833693ffce7 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Mon, 28 Sep 2020 18:36:06 +0200 Subject: [PATCH] avformat/movenc: Don't forget to free fragment buffers The buffers used when fragmented output is enabled have up until now not been freed in the deinit function; they leak e.g. if one errors out of mov_write_trailer() before one reaches the point where they are normally written out and freed. This can e.g. happen if allocating new vos_data fails at the beginning of mov_write_trailer(). Signed-off-by: Andreas Rheinhardt --- libavformat/movenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 6ed93d89ea..5454a9172c 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -6284,9 +6284,11 @@ static void mov_free(AVFormatContext *s) av_freep(&mov->tracks[i].vos_data); ff_mov_cenc_free(&mov->tracks[i].cenc); + ffio_free_dyn_buf(&mov->tracks[i].mdat_buf); } av_freep(&mov->tracks); + ffio_free_dyn_buf(&mov->mdat_buf); } static uint32_t rgb_to_yuv(uint32_t rgb)