mirror of
https://git.ffmpeg.org/ffmpeg.git
synced 2024-12-11 17:55:21 +00:00
rtsp: Don't pass string pointer as format string to ff_url_join
In this case, the string that was passed couldn't contain user-defined data and thus there was no risk for injection bugs, but it's safer this way, if we later change the content of the options string. Signed-off-by: Martin Storsjö <martin@martin.st>
This commit is contained in:
parent
6095388812
commit
d840733937
@ -1234,10 +1234,10 @@ int ff_rtsp_make_setup_request(AVFormatContext *s, const char *host, int port,
|
||||
if (reply->transports[0].source[0]) {
|
||||
ff_url_join(url, sizeof(url), "rtp", NULL,
|
||||
reply->transports[0].source,
|
||||
reply->transports[0].server_port_min, options);
|
||||
reply->transports[0].server_port_min, "%s", options);
|
||||
} else {
|
||||
ff_url_join(url, sizeof(url), "rtp", NULL, host,
|
||||
reply->transports[0].server_port_min, options);
|
||||
reply->transports[0].server_port_min, "%s", options);
|
||||
}
|
||||
if (!(rt->server_type == RTSP_SERVER_WMS && i > 1) &&
|
||||
rtp_set_remote_url(rtsp_st->rtp_handle, url) < 0) {
|
||||
|
Loading…
Reference in New Issue
Block a user