From d3f84dfc0e65201983e88c99b7544d5a60d0165e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Fri, 18 Jun 2010 17:54:56 +0000 Subject: [PATCH] RTSP: Clean up rtsp_hd on failure Since rtsp_hd isn't assigned to rt->rtsp_hd until after the setup phase, the initialized URLContext could be leaked on failures. Originally committed as revision 23643 to svn://svn.ffmpeg.org/ffmpeg/trunk --- libavformat/rtsp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index e762f61e89..6507841cdb 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -1594,12 +1594,14 @@ redirect: /* complete the connection */ if (url_read(rtsp_hd, NULL, 0)) { + url_close(rtsp_hd); err = AVERROR(EIO); goto fail; } /* POST requests */ if (url_open(&rtsp_hd_out, httpname, URL_WRONLY) < 0 ) { + url_close(rtsp_hd); err = AVERROR(EIO); goto fail; }