RepoMirrors/ffmpeg
1
0
Fork 0
mirror of https://git.ffmpeg.org/ffmpeg.git synced 2025-01-21 14:53:10 +00:00
Code Issues Projects Releases Wiki Activity

pthread_frame: use the AVFrame API properly.

Browse Source 
Remove the extended_data workaround, all decoders should now handle this
properly.
This commit is contained in:
Anton Khirnov 2013-11-09 10:14:46 +01:00
parent b605b123ef
commit d351ef47d0
1 changed files with 12 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
libavcodec/pthread_frame.c
View File

@ -66,7 +66,7 @@ typedef struct PerThreadContext {
uint8_t *buf; ///< backup storage for packet data when the input packet is not refcounted uint8_t *buf; ///< backup storage for packet data when the input packet is not refcounted
int allocated_buf_size; ///< Size allocated for buf int allocated_buf_size; ///< Size allocated for buf
AVFrame frame; ///< Output frame (for decoding) or input (for encoding). AVFrame *frame; ///< Output frame (for decoding) or input (for encoding).
int got_frame; ///< The output of got_picture_ptr from the last avcodec_decode_video() call. int got_frame; ///< The output of got_picture_ptr from the last avcodec_decode_video() call.
int result; ///< The result of the last codec decode/encode() call. int result; ///< The result of the last codec decode/encode() call.
@ -140,13 +140,9 @@ static attribute_align_arg void *frame_worker_thread(void *arg)
ff_thread_finish_setup(avctx); ff_thread_finish_setup(avctx);
pthread_mutex_lock(&p->mutex); pthread_mutex_lock(&p->mutex);
avcodec_get_frame_defaults(&p->frame); av_frame_unref(p->frame);
p->got_frame = 0; p->got_frame = 0;
p->result = codec->decode(avctx, &p->frame, &p->got_frame, &p->avpkt); p->result = codec->decode(avctx, p->frame, &p->got_frame, &p->avpkt);
/* many decoders assign whole AVFrames, thus overwriting extended_data;
* make sure it's set correctly */
p->frame.extended_data = p->frame.data;
if (p->state == STATE_SETTING_UP) ff_thread_finish_setup(avctx); if (p->state == STATE_SETTING_UP) ff_thread_finish_setup(avctx);
@ -409,7 +405,7 @@ int ff_thread_decode_frame(AVCodecContext *avctx,
pthread_mutex_unlock(&p->progress_mutex); pthread_mutex_unlock(&p->progress_mutex);
} }
av_frame_move_ref(picture, &p->frame); av_frame_move_ref(picture, p->frame);
*got_picture_ptr = p->got_frame; *got_picture_ptr = p->got_frame;
picture->pkt_dts = p->avpkt.dts; picture->pkt_dts = p->avpkt.dts;
@ -527,7 +523,7 @@ void ff_frame_thread_free(AVCodecContext *avctx, int thread_count)
avctx->codec = NULL; avctx->codec = NULL;
release_delayed_buffers(p); release_delayed_buffers(p);
av_frame_unref(&p->frame); av_frame_free(&p->frame);
} }
for (i = 0; i < thread_count; i++) { for (i = 0; i < thread_count; i++) {
@ -599,6 +595,12 @@ int ff_frame_thread_init(AVCodecContext *avctx)
pthread_cond_init(&p->progress_cond, NULL); pthread_cond_init(&p->progress_cond, NULL);
pthread_cond_init(&p->output_cond, NULL); pthread_cond_init(&p->output_cond, NULL);
p->frame = av_frame_alloc();
if (!p->frame) {
err = AVERROR(ENOMEM);
goto error;
}
p->parent = fctx; p->parent = fctx;
p->avctx = copy; p->avctx = copy;
@ -674,7 +676,7 @@ void ff_thread_flush(AVCodecContext *avctx)
PerThreadContext *p = &fctx->threads[i]; PerThreadContext *p = &fctx->threads[i];
// Make sure decode flush calls with size=0 won't return old frames // Make sure decode flush calls with size=0 won't return old frames
p->got_frame = 0; p->got_frame = 0;
av_frame_unref(&p->frame); av_frame_unref(p->frame);
release_delayed_buffers(p); release_delayed_buffers(p);
} }