RepoMirrors/ffmpeg
1
0
Fork 0
mirror of https://git.ffmpeg.org/ffmpeg.git synced 2024-12-22 15:23:11 +00:00
Code Issues Projects Releases Wiki Activity

avformat/tests/imf: Test ff_imf_parse_cpl_from_xml_dom cleanup on error

Browse Source 
Improves the test; also should fix Coverity issue #1512408.

Reviewed-by: Pierre-Anthony Lemieux <pal@sandflow.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
This commit is contained in:
Andreas Rheinhardt 2022-08-25 22:55:05 +02:00
parent caf26a8a12
commit d27c5bce33
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libavformat/tests/imf.c
View File

@ -338,10 +338,9 @@ static int test_cpl_parsing(void)
return 0; return 0;
} }
static int test_bad_cpl_parsing(void) static int test_bad_cpl_parsing(FFIMFCPL **cpl)
{ {
xmlDocPtr doc; xmlDocPtr doc;
FFIMFCPL *cpl;
int ret; int ret;
doc = xmlReadMemory(cpl_bad_doc, strlen(cpl_bad_doc), NULL, NULL, 0); doc = xmlReadMemory(cpl_bad_doc, strlen(cpl_bad_doc), NULL, NULL, 0);
@ -350,7 +349,7 @@ static int test_bad_cpl_parsing(void)
return 1; return 1;
} }
ret = ff_imf_parse_cpl_from_xml_dom(doc, &cpl); ret = ff_imf_parse_cpl_from_xml_dom(doc, cpl);
xmlFreeDoc(doc); xmlFreeDoc(doc);
if (ret) { if (ret) {
printf("CPL parsing failed.\n"); printf("CPL parsing failed.\n");
@ -506,6 +505,7 @@ fail:
int main(int argc, char *argv[]) int main(int argc, char *argv[])
{ {
FFIMFCPL *cpl;
int ret = 0; int ret = 0;
if (test_cpl_parsing() != 0) if (test_cpl_parsing() != 0)
@ -518,8 +518,12 @@ int main(int argc, char *argv[])
ret = 1; ret = 1;
printf("#### The following should fail ####\n"); printf("#### The following should fail ####\n");
if (test_bad_cpl_parsing() == 0) if (test_bad_cpl_parsing(&cpl) == 0) {
ret = 1; ret = 1;
} else if (cpl) {
printf("Improper cleanup after failed CPL parsing\n");
ret = 1;
}
printf("#### End failing test ####\n"); printf("#### End failing test ####\n");
return ret; return ret;