libavfilter/opencl: Add macro for setting opencl kernel arguments

This commit is contained in:
Danil Iashchenko 2018-06-15 05:55:34 +03:00 committed by Mark Thompson
parent 89651c82b8
commit b41b6b3234
4 changed files with 46 additions and 113 deletions

View File

@ -46,6 +46,21 @@ typedef struct OpenCLFilterContext {
int output_height; int output_height;
} OpenCLFilterContext; } OpenCLFilterContext;
/**
* set argument to specific Kernel.
* This macro relies on usage of local label "fail" and variables:
* avctx, cle and err.
*/
#define CL_SET_KERNEL_ARG(kernel, arg_num, type, arg) \
cle = clSetKernelArg(kernel, arg_num, sizeof(type), arg); \
if (cle != CL_SUCCESS) { \
av_log(avctx, AV_LOG_ERROR, "Failed to set kernel " \
"argument %d: error %d.\n", arg_num, cle); \
err = AVERROR(EIO); \
goto fail; \
}
/** /**
* Return that all inputs and outputs support only AV_PIX_FMT_OPENCL. * Return that all inputs and outputs support only AV_PIX_FMT_OPENCL.
*/ */

View File

@ -204,43 +204,12 @@ static int convolution_opencl_filter_frame(AVFilterLink *inlink, AVFrame *input)
if (!dst) if (!dst)
break; break;
cle = clSetKernelArg(ctx->kernel, 0, sizeof(cl_mem), &dst); CL_SET_KERNEL_ARG(ctx->kernel, 0, cl_mem, &dst);
if (cle != CL_SUCCESS) { CL_SET_KERNEL_ARG(ctx->kernel, 1, cl_mem, &src);
av_log(avctx, AV_LOG_ERROR, "Failed to set kernel " CL_SET_KERNEL_ARG(ctx->kernel, 2, cl_int, &ctx->dims[p]);
"destination image argument: %d.\n", cle); CL_SET_KERNEL_ARG(ctx->kernel, 3, cl_mem, &ctx->matrix[p]);
goto fail; CL_SET_KERNEL_ARG(ctx->kernel, 4, cl_float, &ctx->rdivs[p]);
} CL_SET_KERNEL_ARG(ctx->kernel, 5, cl_float, &ctx->biases[p]);
cle = clSetKernelArg(ctx->kernel, 1, sizeof(cl_mem), &src);
if (cle != CL_SUCCESS) {
av_log(avctx, AV_LOG_ERROR, "Failed to set kernel "
"source image argument: %d.\n", cle);
goto fail;
}
cle = clSetKernelArg(ctx->kernel, 2, sizeof(cl_int), &ctx->dims[p]);
if (cle != CL_SUCCESS) {
av_log(avctx, AV_LOG_ERROR, "Failed to set kernel "
"matrix size argument: %d.\n", cle);
goto fail;
}
cle = clSetKernelArg(ctx->kernel, 3, sizeof(cl_mem), &ctx->matrix[p]);
if (cle != CL_SUCCESS) {
av_log(avctx, AV_LOG_ERROR, "Failed to set kernel "
"matrix argument: %d.\n", cle);
goto fail;
}
cle = clSetKernelArg(ctx->kernel, 4, sizeof(cl_float), &ctx->rdivs[p]);
if (cle != CL_SUCCESS) {
av_log(avctx, AV_LOG_ERROR, "Failed to set kernel "
"rdiv argument: %d.\n", cle);
goto fail;
}
cle = clSetKernelArg(ctx->kernel, 5, sizeof(cl_float), &ctx->biases[p]);
if (cle != CL_SUCCESS) {
av_log(avctx, AV_LOG_ERROR, "Failed to set kernel "
"bias argument: %d.\n", cle);
goto fail;
}
err = ff_opencl_filter_work_size_from_image(avctx, global_work, output, p, 0); err = ff_opencl_filter_work_size_from_image(avctx, global_work, output, p, 0);
if (err < 0) if (err < 0)

View File

@ -167,47 +167,39 @@ static int overlay_opencl_blend(FFFrameSync *fs)
kernel_arg = 0; kernel_arg = 0;
mem = (cl_mem)output->data[plane]; mem = (cl_mem)output->data[plane];
cle = clSetKernelArg(ctx->kernel, kernel_arg++, sizeof(cl_mem), &mem); CL_SET_KERNEL_ARG(ctx->kernel, kernel_arg, cl_mem, &mem);
if (cle != CL_SUCCESS) kernel_arg++;
goto fail_kernel_arg;
mem = (cl_mem)input_main->data[plane]; mem = (cl_mem)input_main->data[plane];
cle = clSetKernelArg(ctx->kernel, kernel_arg++, sizeof(cl_mem), &mem); CL_SET_KERNEL_ARG(ctx->kernel, kernel_arg, cl_mem, &mem);
if (cle != CL_SUCCESS) kernel_arg++;
goto fail_kernel_arg;
mem = (cl_mem)input_overlay->data[plane]; mem = (cl_mem)input_overlay->data[plane];
cle = clSetKernelArg(ctx->kernel, kernel_arg++, sizeof(cl_mem), &mem); CL_SET_KERNEL_ARG(ctx->kernel, kernel_arg, cl_mem, &mem);
if (cle != CL_SUCCESS) kernel_arg++;
goto fail_kernel_arg;
if (ctx->alpha_separate) { if (ctx->alpha_separate) {
mem = (cl_mem)input_overlay->data[ctx->nb_planes]; mem = (cl_mem)input_overlay->data[ctx->nb_planes];
cle = clSetKernelArg(ctx->kernel, kernel_arg++, sizeof(cl_mem), &mem); CL_SET_KERNEL_ARG(ctx->kernel, kernel_arg, cl_mem, &mem);
if (cle != CL_SUCCESS) kernel_arg++;
goto fail_kernel_arg;
} }
x = ctx->x_position / (plane == 0 ? 1 : ctx->x_subsample); x = ctx->x_position / (plane == 0 ? 1 : ctx->x_subsample);
y = ctx->y_position / (plane == 0 ? 1 : ctx->y_subsample); y = ctx->y_position / (plane == 0 ? 1 : ctx->y_subsample);
cle = clSetKernelArg(ctx->kernel, kernel_arg++, sizeof(cl_int), &x); CL_SET_KERNEL_ARG(ctx->kernel, kernel_arg, cl_int, &x);
if (cle != CL_SUCCESS) kernel_arg++;
goto fail_kernel_arg; CL_SET_KERNEL_ARG(ctx->kernel, kernel_arg, cl_int, &y);
cle = clSetKernelArg(ctx->kernel, kernel_arg++, sizeof(cl_int), &y); kernel_arg++;
if (cle != CL_SUCCESS)
goto fail_kernel_arg;
if (ctx->alpha_separate) { if (ctx->alpha_separate) {
cl_int alpha_adj_x = plane == 0 ? 1 : ctx->x_subsample; cl_int alpha_adj_x = plane == 0 ? 1 : ctx->x_subsample;
cl_int alpha_adj_y = plane == 0 ? 1 : ctx->y_subsample; cl_int alpha_adj_y = plane == 0 ? 1 : ctx->y_subsample;
cle = clSetKernelArg(ctx->kernel, kernel_arg++, sizeof(cl_int), &alpha_adj_x); CL_SET_KERNEL_ARG(ctx->kernel, kernel_arg, cl_int, &alpha_adj_x);
if (cle != CL_SUCCESS) kernel_arg++;
goto fail_kernel_arg; CL_SET_KERNEL_ARG(ctx->kernel, kernel_arg, cl_int, &alpha_adj_y);
cle = clSetKernelArg(ctx->kernel, kernel_arg++, sizeof(cl_int), &alpha_adj_y); kernel_arg++;
if (cle != CL_SUCCESS)
goto fail_kernel_arg;
} }
err = ff_opencl_filter_work_size_from_image(avctx, global_work, err = ff_opencl_filter_work_size_from_image(avctx, global_work,
@ -241,10 +233,6 @@ static int overlay_opencl_blend(FFFrameSync *fs)
return ff_filter_frame(outlink, output); return ff_filter_frame(outlink, output);
fail_kernel_arg:
av_log(avctx, AV_LOG_ERROR, "Failed to set kernel arg %d: %d.\n",
kernel_arg, cle);
err = AVERROR(EIO);
fail: fail:
av_frame_free(&output); av_frame_free(&output);
return err; return err;

View File

@ -268,56 +268,17 @@ static int unsharp_opencl_filter_frame(AVFilterLink *inlink, AVFrame *input)
if (!dst) if (!dst)
break; break;
cle = clSetKernelArg(ctx->kernel, 0, sizeof(cl_mem), &dst); CL_SET_KERNEL_ARG(ctx->kernel, 0, cl_mem, &dst);
if (cle != CL_SUCCESS) { CL_SET_KERNEL_ARG(ctx->kernel, 1, cl_mem, &src);
av_log(avctx, AV_LOG_ERROR, "Failed to set kernel " CL_SET_KERNEL_ARG(ctx->kernel, 2, cl_int, &ctx->plane[p].size_x);
"destination image argument: %d.\n", cle); CL_SET_KERNEL_ARG(ctx->kernel, 3, cl_int, &ctx->plane[p].size_y);
goto fail; CL_SET_KERNEL_ARG(ctx->kernel, 4, cl_float, &ctx->plane[p].amount);
}
cle = clSetKernelArg(ctx->kernel, 1, sizeof(cl_mem), &src);
if (cle != CL_SUCCESS) {
av_log(avctx, AV_LOG_ERROR, "Failed to set kernel "
"source image argument: %d.\n", cle);
goto fail;
}
cle = clSetKernelArg(ctx->kernel, 2, sizeof(cl_int), &ctx->plane[p].size_x);
if (cle != CL_SUCCESS) {
av_log(avctx, AV_LOG_ERROR, "Failed to set kernel "
"matrix size argument: %d.\n", cle);
goto fail;
}
cle = clSetKernelArg(ctx->kernel, 3, sizeof(cl_int), &ctx->plane[p].size_y);
if (cle != CL_SUCCESS) {
av_log(avctx, AV_LOG_ERROR, "Failed to set kernel "
"matrix size argument: %d.\n", cle);
goto fail;
}
cle = clSetKernelArg(ctx->kernel, 4, sizeof(cl_float), &ctx->plane[p].amount);
if (cle != CL_SUCCESS) {
av_log(avctx, AV_LOG_ERROR, "Failed to set kernel "
"amount argument: %d.\n", cle);
goto fail;
}
if (ctx->global) { if (ctx->global) {
cle = clSetKernelArg(ctx->kernel, 5, sizeof(cl_mem), &ctx->plane[p].matrix); CL_SET_KERNEL_ARG(ctx->kernel, 5, cl_mem, &ctx->plane[p].matrix);
if (cle != CL_SUCCESS) {
av_log(avctx, AV_LOG_ERROR, "Failed to set kernel "
"matrix argument: %d.\n", cle);
goto fail;
}
} else { } else {
cle = clSetKernelArg(ctx->kernel, 5, sizeof(cl_mem), &ctx->plane[p].coef_x); CL_SET_KERNEL_ARG(ctx->kernel, 5, cl_mem, &ctx->plane[p].coef_x);
if (cle != CL_SUCCESS) { CL_SET_KERNEL_ARG(ctx->kernel, 6, cl_mem, &ctx->plane[p].coef_y);
av_log(avctx, AV_LOG_ERROR, "Failed to set kernel "
"x-coef argument: %d.\n", cle);
goto fail;
}
cle = clSetKernelArg(ctx->kernel, 6, sizeof(cl_mem), &ctx->plane[p].coef_y);
if (cle != CL_SUCCESS) {
av_log(avctx, AV_LOG_ERROR, "Failed to set kernel "
"y-coef argument: %d.\n", cle);
goto fail;
}
} }
err = ff_opencl_filter_work_size_from_image(avctx, global_work, output, p, err = ff_opencl_filter_work_size_from_image(avctx, global_work, output, p,