RepoMirrors/ffmpeg
1
0
Fork 0
mirror of https://git.ffmpeg.org/ffmpeg.git synced 2025-02-13 10:10:03 +00:00
Code Issues Projects Releases Wiki Activity

avformat/oggparsevorbis: free base64 encoded data immediately after decoding it

Browse Source 
It has no use afterwards and freeing it before calling ff_flac_parse_picture()
may help prevent OOM issues on memory constrained scenarios.

Signed-off-by: James Almer <jamrial@gmail.com>
This commit is contained in:
James Almer 2016-06-16 19:17:26 -03:00
parent 8b5b756c4d
commit afd04058bc
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libavformat/oggparsevorbis.c
View File

@ -161,10 +161,11 @@ int ff_vorbis_comment(AVFormatContext *as, AVDictionary **m,
av_freep(&ct); av_freep(&ct);
continue; continue;
} }
if ((ret = av_base64_decode(pict, ct, len)) > 0) ret = av_base64_decode(pict, ct, len);
ret = ff_flac_parse_picture(as, pict, ret);
av_freep(&tt); av_freep(&tt);
av_freep(&ct); av_freep(&ct);
if (ret > 0)
ret = ff_flac_parse_picture(as, pict, ret);
av_freep(&pict); av_freep(&pict);
if (ret < 0) { if (ret < 0) {
av_log(as, AV_LOG_WARNING, "Failed to parse cover art block.\n"); av_log(as, AV_LOG_WARNING, "Failed to parse cover art block.\n");