RepoMirrors/ffmpeg
1
0
Fork 0
mirror of https://git.ffmpeg.org/ffmpeg.git synced 2024-12-27 01:42:20 +00:00
Code Issues Projects Releases Wiki Activity

avcodec/vc2enc: Fix overflows with storing large values

Browse Source 
Fixes: left shift of 1431634944 by 2 places cannot be represented in type 'int'
Fixes: left shift of 1073741824 by 1 places cannot be represented in type 'int'
Fixes: 69061/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC2_fuzzer-6325700826038272

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
This commit is contained in:
Michael Niedermayer 2024-06-17 22:43:22 +02:00
parent 8ca60e14d2
commit af99358353
No known key found for this signature in database
GPG Key ID: B18E8928B3948D64
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libavcodec/vc2enc.c
View File

@ -189,7 +189,9 @@ typedef struct VC2EncContext {
static av_always_inline void put_vc2_ue_uint(PutBitContext *pb, uint32_t val) static av_always_inline void put_vc2_ue_uint(PutBitContext *pb, uint32_t val)
{ {
int i; int i;
int pbits = 0, bits = 0, topbit = 1, maxval = 1; int bits = 0;
unsigned topbit = 1, maxval = 1;
uint64_t pbits = 0;
if (!val++) { if (!val++) {
put_bits(pb, 1, 1); put_bits(pb, 1, 1);
@ -206,12 +208,13 @@ static av_always_inline void put_vc2_ue_uint(PutBitContext *pb, uint32_t val)
for (i = 0; i < bits; i++) { for (i = 0; i < bits; i++) {
topbit >>= 1; topbit >>= 1;
av_assert2(pbits <= UINT64_MAX>>3);
pbits <<= 2; pbits <<= 2;
if (val & topbit) if (val & topbit)
pbits |= 0x1; pbits |= 0x1;
} }
put_bits(pb, bits*2 + 1, (pbits << 1) | 1); put_bits64(pb, bits*2 + 1, (pbits << 1) | 1);
} }
static av_always_inline int count_vc2_ue_uint(uint32_t val) static av_always_inline int count_vc2_ue_uint(uint32_t val)