RepoMirrors/ffmpeg
1
0
Fork 0
mirror of https://git.ffmpeg.org/ffmpeg.git synced 2024-12-24 16:22:37 +00:00
Code Issues Projects Releases Wiki Activity

avcodec/libmp3lame: Remove redundant av_packet_unref()

Browse Source 
The AVPacket given to an encoder's encode callback
is unreferenced generically on error.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
This commit is contained in:
Andreas Rheinhardt 2023-03-13 05:00:44 +01:00
parent 590d169bdb
commit af26a8ffbb
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libavcodec/libmp3lame.c
View File

@ -280,17 +280,14 @@ static int mp3lame_encode_frame(AVCodecContext *avctx, AVPacket *avpkt,
// Check if subtraction resulted in an overflow // Check if subtraction resulted in an overflow
if ((discard_padding < avctx->frame_size) != (avpkt->duration > 0)) { if ((discard_padding < avctx->frame_size) != (avpkt->duration > 0)) {
av_log(avctx, AV_LOG_ERROR, "discard padding overflow\n"); av_log(avctx, AV_LOG_ERROR, "discard padding overflow\n");
av_packet_unref(avpkt);
return AVERROR(EINVAL); return AVERROR(EINVAL);
} }
if ((!s->delay_sent && avctx->initial_padding > 0) || discard_padding > 0) { if ((!s->delay_sent && avctx->initial_padding > 0) || discard_padding > 0) {
uint8_t* side_data = av_packet_new_side_data(avpkt, uint8_t* side_data = av_packet_new_side_data(avpkt,
AV_PKT_DATA_SKIP_SAMPLES, AV_PKT_DATA_SKIP_SAMPLES,
10); 10);
if(!side_data) { if (!side_data)
av_packet_unref(avpkt);
return AVERROR(ENOMEM); return AVERROR(ENOMEM);
}
if (!s->delay_sent) { if (!s->delay_sent) {
AV_WL32(side_data, avctx->initial_padding); AV_WL32(side_data, avctx->initial_padding);
s->delay_sent = 1; s->delay_sent = 1;