From a740263d7e7be5bb909ae83a44b21cc8cf8c9274 Mon Sep 17 00:00:00 2001 From: Marton Balint Date: Sat, 6 Feb 2016 17:23:02 +0100 Subject: [PATCH] avutil/dict: do not realloc entries when deleting a non-existing item Deleting a non-existing item should not invalidate existing entries returned with av_dict_get. Reviewed-by: Michael Niedermayer Signed-off-by: Marton Balint --- libavutil/dict.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/dict.c b/libavutil/dict.c index 8bb65a13fe..12035627f9 100644 --- a/libavutil/dict.c +++ b/libavutil/dict.c @@ -98,7 +98,7 @@ int av_dict_set(AVDictionary **pm, const char *key, const char *value, av_free(tag->value); av_free(tag->key); *tag = m->elems[--m->count]; - } else { + } else if (copy_value) { AVDictionaryEntry *tmp = av_realloc(m->elems, (m->count + 1) * sizeof(*m->elems)); if (!tmp)