From a18e04bcf989a9d7f5629c573f9d70f8a020c7a7 Mon Sep 17 00:00:00 2001 From: Dustin Brody Date: Thu, 25 Aug 2011 19:47:01 -0400 Subject: [PATCH] mjpeg: treat external huffman table setup failure as codec init failure if external huffman table use requested Signed-off-by: Anton Khirnov --- libavcodec/mjpegdec.c | 4 ++-- libavcodec/mxpegdec.c | 4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/libavcodec/mjpegdec.c b/libavcodec/mjpegdec.c index 81effb4f8c..b9db777fe1 100644 --- a/libavcodec/mjpegdec.c +++ b/libavcodec/mjpegdec.c @@ -101,8 +101,8 @@ av_cold int ff_mjpeg_decode_init(AVCodecContext *avctx) av_log(avctx, AV_LOG_INFO, "mjpeg: using external huffman table\n"); init_get_bits(&s->gb, avctx->extradata, avctx->extradata_size*8); if (ff_mjpeg_decode_dht(s)) { - av_log(avctx, AV_LOG_ERROR, "mjpeg: error using external huffman table, switching back to internal\n"); - build_basic_mjpeg_vlc(s); + av_log(avctx, AV_LOG_ERROR, "mjpeg: error using external huffman table\n"); + return AVERROR_INVALIDDATA; } } if (avctx->extradata_size > 9 && diff --git a/libavcodec/mxpegdec.c b/libavcodec/mxpegdec.c index 92fd244ec7..fd3fef47a9 100644 --- a/libavcodec/mxpegdec.c +++ b/libavcodec/mxpegdec.c @@ -47,9 +47,7 @@ static av_cold int mxpeg_decode_init(AVCodecContext *avctx) s->picture[0].reference = s->picture[1].reference = 3; s->jpg.picture_ptr = &s->picture[0]; - ff_mjpeg_decode_init(avctx); - - return 0; + return ff_mjpeg_decode_init(avctx); } static int mxpeg_decode_app(MXpegDecodeContext *s,